Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0042671
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2020-01-02 08:542020-01-03 09:04
ReporterguillermogilView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityhighResolutionfixedFixed in VersionRR20Q1
StatusclosedFix in branchFixed in SCM revisionbb931e86ed1a
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0042671: Save on PostAddPaymentHook breaks custom functionality

DescriptionSave on PostAddPaymentHook breaks custom functionality on 20Q1 due to a new save done after the hook
Steps To ReproduceOn postAddPaymentHook execute the following:
order.trigger('paymentDone', OB.UTIL.isOpenDrawer(payment));

WebPOS breaks.
Proposed SolutionSee diff attached.

With the proposed diff the hook has control on whether the save should happen or not, and therefore can prevent the problem from happening.
TagsNo tags attached.
Attached Filesdiff file icon saveChangesPostAddPayment.diff [^] (820 bytes) 2020-01-02 08:55 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0042672RR20Q1 closedranjith_qualiantech_com Save on PostAddPaymentHook breaks custom functionality 
caused by defect 0042603 closedranjith_qualiantech_com If a payment is modified in OBPOS_postAddPayment and the POS is refreshed (F5) that change is lost 

-  Notes
(0116612)
hgbot (developer)
2020-01-03 07:09

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: bb931e86ed1abd1c67ddc3a5ca409c6ed945a663
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jan 03 11:39:29 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bb931e86ed1abd1c67ddc3a5ca409c6ed945a663 [^]

Fixed issue 42671 : Updated PostAddPayment hook arguments

* saveChanges values should be added to PostAddPayment hook

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---

- Issue History
Date Modified Username Field Change
2020-01-02 08:54 guillermogil New Issue
2020-01-02 08:54 guillermogil Assigned To => Retail
2020-01-02 08:54 guillermogil Resolution time => 1547938800
2020-01-02 08:54 guillermogil Triggers an Emergency Pack => No
2020-01-02 08:54 guillermogil Relationship added caused by 0042603
2020-01-02 08:55 guillermogil File Added: saveChangesPostAddPayment.diff
2020-01-02 08:56 marvintm Proposed Solution updated
2020-01-02 08:58 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2020-01-02 08:58 marvintm Status new => scheduled
2020-01-02 15:19 marvintm Resolution time 1547938800 => 1579474800
2020-01-03 07:09 hgbot Checkin
2020-01-03 07:09 hgbot Note Added: 0116612
2020-01-03 07:09 hgbot Status scheduled => resolved
2020-01-03 07:09 hgbot Resolution open => fixed
2020-01-03 07:09 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bb931e86ed1abd1c67ddc3a5ca409c6ed945a663 [^]
2020-01-03 09:04 marvintm Review Assigned To => marvintm
2020-01-03 09:04 marvintm Status resolved => closed
2020-01-03 09:04 marvintm Fixed in Version => RR20Q1

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker