Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042671Retail ModulesWeb POSpublic2020-01-02 08:542020-01-03 09:04
Reporterguillermogil 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042671: Save on PostAddPaymentHook breaks custom functionality
DescriptionSave on PostAddPaymentHook breaks custom functionality on 20Q1 due to a new save done after the hook
Steps To ReproduceOn postAddPaymentHook execute the following:
order.trigger('paymentDone', OB.UTIL.isOpenDrawer(payment));

WebPOS breaks.
Proposed SolutionSee diff attached.

With the proposed diff the hook has control on whether the save should happen or not, and therefore can prevent the problem from happening.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0042672RR20Q1 closed ranjith_qualiantech_com Save on PostAddPaymentHook breaks custom functionality 
caused by defect 0042603 closed ranjith_qualiantech_com If a payment is modified in OBPOS_postAddPayment and the POS is refreshed (F5) that change is lost 
Attached Filesdiff saveChangesPostAddPayment.diff (820) 2020-01-02 08:55
https://issues.openbravo.com/file_download.php?file_id=13745&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-01-02 08:54guillermogilNew Issue
2020-01-02 08:54guillermogilAssigned To => Retail
2020-01-02 08:54guillermogilResolution time => 1547938800
2020-01-02 08:54guillermogilTriggers an Emergency Pack => No
2020-01-02 08:54guillermogilRelationship addedcaused by 0042603
2020-01-02 08:55guillermogilFile Added: saveChangesPostAddPayment.diff
2020-01-02 08:56marvintmProposed Solution updated
2020-01-02 08:58ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-01-02 08:58marvintmStatusnew => scheduled
2020-01-02 15:19marvintmResolution time1547938800 => 1579474800
2020-01-03 07:09hgbotCheckin
2020-01-03 07:09hgbotNote Added: 0116612
2020-01-03 07:09hgbotStatusscheduled => resolved
2020-01-03 07:09hgbotResolutionopen => fixed
2020-01-03 07:09hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bb931e86ed1abd1c67ddc3a5ca409c6ed945a663 [^]
2020-01-03 09:04marvintmReview Assigned To => marvintm
2020-01-03 09:04marvintmStatusresolved => closed
2020-01-03 09:04marvintmFixed in Version => RR20Q1

Notes
(0116612)
hgbot   
2020-01-03 07:09   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: bb931e86ed1abd1c67ddc3a5ca409c6ed945a663
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jan 03 11:39:29 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bb931e86ed1abd1c67ddc3a5ca409c6ed945a663 [^]

Fixed issue 42671 : Updated PostAddPayment hook arguments

* saveChanges values should be added to PostAddPayment hook

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---