Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0042402 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Retail Modules] Discounts and Promotions | critical | always | 2019-11-25 15:31 | 2019-11-28 12:30 | |||
| Reporter | sebastien_liron | View Status | public | |||||
| Assigned To | ranjith_qualiantech_com | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | RR19Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 7ee4ebb9838e | ||||
| Projection | none | ETA | none | Target Version | RR19Q4 | |||
| OS | Linux 64 bit | Database | PostgreSQL | Java version | 7.x | |||
| OS Version | Openbravo Appliance 14.04 | Database version | 9.3.x | Ant version | 1.9.x | |||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | marvintm | |||||||
| Regression level | Pre packaging ( pi ) | |||||||
| Regression date | ||||||||
| Regression introduced in release | pi | |||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0042402: Manual discount can be higher than the line price | |||||||
| Description | Manual discount can be higher than the line price, If I want I can create a variable manual discount of 800 for a product that costs 700, the total will show a -100 balance in favor of customer. It should present a 0 balance. | |||||||
| Steps To Reproduce | - add a product to ticket - click on the line, then on discount to add a variable discount - before applying the discount set the manual discount to more than the product price ( if line is 700 set the discount to 800 ) - apply the discount - see the total as -100 ( or more depending on your entry ) and not 0. | |||||||
| Proposed Solution | Thee should be a control within the addManualPromotion flow to check if the line price is <= to the manual discount. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0115886) hgbot (developer) 2019-11-27 13:46 |
Repository: retail/backports/3.0RR19Q4/org.openbravo.retail.discounts Changeset: 7ee4ebb9838e6668969110fc45f23bb08d46073d Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Wed Nov 27 18:16:10 2019 +0530 URL: http://code.openbravo.com/retail/backports/3.0RR19Q4/org.openbravo.retail.discounts/rev/7ee4ebb9838e6668969110fc45f23bb08d46073d [^] Fixed issue 42402 : Manual Discount amt should be maximum of Available Line amt * When discount amount is more than line available amount,then discount amount should be updated with line available amount --- M src-test/org/openbravo/retail/discounts/test/unittests/DiscountUserDefinedAmountTest.java M web/org.openbravo.retail.discounts/js/discountsengine/common/rules/manual-promotions-discount.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2019-11-26 15:16 | marvintm | Type | defect => backport |
| 2019-11-26 15:16 | marvintm | Target Version | => RR19Q4 |
| 2019-11-27 13:46 | hgbot | Checkin | |
| 2019-11-27 13:46 | hgbot | Note Added: 0115886 | |
| 2019-11-27 13:46 | hgbot | Status | scheduled => resolved |
| 2019-11-27 13:46 | hgbot | Resolution | open => fixed |
| 2019-11-27 13:46 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/retail/backports/3.0RR19Q4/org.openbravo.retail.discounts/rev/7ee4ebb9838e6668969110fc45f23bb08d46073d [^] |
| 2019-11-28 12:30 | marvintm | Review Assigned To | => marvintm |
| 2019-11-28 12:30 | marvintm | Status | resolved => closed |
| 2019-11-28 12:30 | marvintm | Fixed in Version | => RR19Q4 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |