Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0042390
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Discounts and Promotionscriticalalways2019-11-25 15:312019-11-28 12:31
Reportersebastien_lironView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityhighResolutionfixedFixed in VersionRR20Q1
StatusclosedFix in branchFixed in SCM revisionde58aadbc473
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version7.x
OS VersionOpenbravo Appliance 14.04Database version9.3.xAnt version1.9.x
Product VersionpiSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket
Regression levelPre packaging ( pi )
Regression date
Regression introduced in releasepi
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0042390: Manual discount can be higher than the line price

DescriptionManual discount can be higher than the line price, If I want I can create a variable manual discount of 800 for a product that costs 700, the total will show a -100 balance in favor of customer. It should present a 0 balance.
Steps To Reproduce- add a product to ticket
- click on the line, then on discount to add a variable discount
- before applying the discount set the manual discount to more than the product price ( if line is 700 set the discount to 800 )
- apply the discount
- see the total as -100 ( or more depending on your entry ) and not 0.
Proposed SolutionThee should be a control within the addManualPromotion flow to check if the line price is <= to the manual discount.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0042402RR19Q4 closedranjith_qualiantech_com Manual discount can be higher than the line price 

-  Notes
(0115860)
hgbot (developer)
2019-11-27 08:16

 Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: de58aadbc473a7e20a9e9e68f0f86624162170ad
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Nov 27 12:45:46 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/de58aadbc473a7e20a9e9e68f0f86624162170ad [^]

Fixed issue 42390 : Manual Discount amt should be maximum of Available Line amt

* When discount amount is more than line available amount,then
  discount amount should be updated with line available amount

---
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountUserDefinedAmountTest.java
M web/org.openbravo.retail.discounts/js/discountsengine/common/rules/manual-promotions-discount.js
---

- Issue History
Date Modified Username Field Change
2019-11-25 15:31 sebastien_liron New Issue
2019-11-25 15:31 sebastien_liron Assigned To => Retail
2019-11-25 15:31 sebastien_liron Triggers an Emergency Pack => No
2019-11-25 15:50 sebastien_liron Issue Monitored: sebastien_liron
2019-11-25 15:50 sebastien_liron Issue End Monitor: sebastien_liron
2019-11-25 15:53 guillermogil OBNetwork customer => Gold
2019-11-25 15:53 guillermogil Resolution time => 1575241200
2019-11-25 15:53 guillermogil Regression level => Pre packaging ( pi )
2019-11-25 15:53 guillermogil Regression introduced in release => pi
2019-11-25 16:22 guillermogil Description Updated View Revisions
2019-11-25 16:35 martinsdan Issue Monitored: martinsdan
2019-11-26 06:25 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2019-11-26 10:35 ranjith_qualiantech_com Status new => scheduled
2019-11-26 15:16 marvintm Status scheduled => acknowledged
2019-11-26 15:16 marvintm Status acknowledged => scheduled
2019-11-27 08:16 hgbot Checkin
2019-11-27 08:16 hgbot Note Added: 0115860
2019-11-27 08:16 hgbot Status scheduled => resolved
2019-11-27 08:16 hgbot Resolution open => fixed
2019-11-27 08:16 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/de58aadbc473a7e20a9e9e68f0f86624162170ad [^]
2019-11-28 12:31 marvintm Review Assigned To => marvintm
2019-11-28 12:31 marvintm Status resolved => closed
2019-11-28 12:31 marvintm Fixed in Version => RR20Q1

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker