Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042390Retail ModulesDiscounts and Promotionspublic2019-11-25 15:312019-11-28 12:31
Reportersebastien_liron 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Versionpi 
Target VersionFixed in VersionRR20Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket
Regression levelPre packaging ( pi )
Regression date
Regression introduced in releasepi
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042390: Manual discount can be higher than the line price
DescriptionManual discount can be higher than the line price, If I want I can create a variable manual discount of 800 for a product that costs 700, the total will show a -100 balance in favor of customer. It should present a 0 balance.
Steps To Reproduce- add a product to ticket
- click on the line, then on discount to add a variable discount
- before applying the discount set the manual discount to more than the product price ( if line is 700 set the discount to 800 )
- apply the discount
- see the total as -100 ( or more depending on your entry ) and not 0.
Proposed SolutionThee should be a control within the addManualPromotion flow to check if the line price is <= to the manual discount.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0042402RR19Q4 closed ranjith_qualiantech_com Manual discount can be higher than the line price 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-11-25 15:31sebastien_lironNew Issue
2019-11-25 15:31sebastien_lironAssigned To => Retail
2019-11-25 15:31sebastien_lironTriggers an Emergency Pack => No
2019-11-25 15:50sebastien_lironIssue Monitored: sebastien_liron
2019-11-25 15:50sebastien_lironIssue End Monitor: sebastien_liron
2019-11-25 15:53guillermogilOBNetwork customer => Gold
2019-11-25 15:53guillermogilResolution time => 1575241200
2019-11-25 15:53guillermogilRegression level => Pre packaging ( pi )
2019-11-25 15:53guillermogilRegression introduced in release => pi
2019-11-25 16:22guillermogilDescription Updatedbug_revision_view_page.php?rev_id=19769#r19769
2019-11-25 16:35martinsdanIssue Monitored: martinsdan
2019-11-26 06:25ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-11-26 10:35ranjith_qualiantech_comStatusnew => scheduled
2019-11-26 15:16marvintmStatusscheduled => acknowledged
2019-11-26 15:16marvintmStatusacknowledged => scheduled
2019-11-27 08:16hgbotCheckin
2019-11-27 08:16hgbotNote Added: 0115860
2019-11-27 08:16hgbotStatusscheduled => resolved
2019-11-27 08:16hgbotResolutionopen => fixed
2019-11-27 08:16hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/de58aadbc473a7e20a9e9e68f0f86624162170ad [^]
2019-11-28 12:31marvintmReview Assigned To => marvintm
2019-11-28 12:31marvintmStatusresolved => closed
2019-11-28 12:31marvintmFixed in Version => RR20Q1

Notes
(0115860)
hgbot   
2019-11-27 08:16   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: de58aadbc473a7e20a9e9e68f0f86624162170ad
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Nov 27 12:45:46 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/de58aadbc473a7e20a9e9e68f0f86624162170ad [^]

Fixed issue 42390 : Manual Discount amt should be maximum of Available Line amt

* When discount amount is more than line available amount,then
  discount amount should be updated with line available amount

---
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountUserDefinedAmountTest.java
M web/org.openbravo.retail.discounts/js/discountsengine/common/rules/manual-promotions-discount.js
---