Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042402Retail ModulesDiscounts and Promotionspublic2019-11-25 15:312019-11-28 12:30
Reportersebastien_liron 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Versionpi 
Target VersionRR19Q4Fixed in VersionRR19Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression levelPre packaging ( pi )
Regression date
Regression introduced in releasepi
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042402: Manual discount can be higher than the line price
DescriptionManual discount can be higher than the line price, If I want I can create a variable manual discount of 800 for a product that costs 700, the total will show a -100 balance in favor of customer. It should present a 0 balance.
Steps To Reproduce- add a product to ticket
- click on the line, then on discount to add a variable discount
- before applying the discount set the manual discount to more than the product price ( if line is 700 set the discount to 800 )
- apply the discount
- see the total as -100 ( or more depending on your entry ) and not 0.
Proposed SolutionThee should be a control within the addManualPromotion flow to check if the line price is <= to the manual discount.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0042390 closed ranjith_qualiantech_com Manual discount can be higher than the line price 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-11-26 15:16marvintmTypedefect => backport
2019-11-26 15:16marvintmTarget Version => RR19Q4
2019-11-27 13:46hgbotCheckin
2019-11-27 13:46hgbotNote Added: 0115886
2019-11-27 13:46hgbotStatusscheduled => resolved
2019-11-27 13:46hgbotResolutionopen => fixed
2019-11-27 13:46hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR19Q4/org.openbravo.retail.discounts/rev/7ee4ebb9838e6668969110fc45f23bb08d46073d [^]
2019-11-28 12:30marvintmReview Assigned To => marvintm
2019-11-28 12:30marvintmStatusresolved => closed
2019-11-28 12:30marvintmFixed in Version => RR19Q4

Notes
(0115886)
hgbot   
2019-11-27 13:46   
Repository: retail/backports/3.0RR19Q4/org.openbravo.retail.discounts
Changeset: 7ee4ebb9838e6668969110fc45f23bb08d46073d
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Nov 27 18:16:10 2019 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR19Q4/org.openbravo.retail.discounts/rev/7ee4ebb9838e6668969110fc45f23bb08d46073d [^]

Fixed issue 42402 : Manual Discount amt should be maximum of Available Line amt

* When discount amount is more than line available amount,then
discount amount should be updated with line available amount

---
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountUserDefinedAmountTest.java
M web/org.openbravo.retail.discounts/js/discountsengine/common/rules/manual-promotions-discount.js
---