Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0041227
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersmajoralways2019-07-02 13:062019-07-23 15:45
ReportervmromanosView Statuspublic 
Assigned Tovmromanos 
PriorityimmediateResolutionfixedFixed in Version3.0PR19Q4
StatusclosedFix in branchFixed in SCM revision5beecb7e9aa7
ProjectionnoneETAnoneTarget Version3.0PR19Q4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToSandrahuguet
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0041227: API Change: One-to-many cleanup (Functional team)

DescriptionDue to the one-to-many cleanup project, many relationships between entities have been removed from the Java model classes generated by DAL. You can see details about the affected columns at https://docs.google.com/spreadsheets/d/1hdwjGM4_3TJ-9Bcylh_w_MM54_1T_cUlicaPfEyH1MQ [^]

This is done by setting the AD_Column.is_child_property_in_parent to 'N' for the selected columns.

This action creates an expected API change that widely affects many Openbravo 3 classes. More details: http://ci.openbravo.com/view/try/job/try-api/7262/consoleFull [^]


The approach we have followed for the cleanup is:
1. to keep always any relationship already consumed by internal or external modules (any module published in the forge).
2. for the rest of the relationships, try to be aggressive and remove as many as possible, leaving only the relationships that clearly make sense from a Functional POV and that are safe from a Performance POV, ie which don't load too many objects in memory on a standard environment.


Due to the above approach the API change risk could be classified as "high". However, in case of any external module not currently published in the forge is affected by this change, the developer can easily revert back to the previous API by running the following SQL and exporting the result to a template:

update ad_column set is_child_property_in_parent = 'Y' where ad_column_id = '<AffectedColumnID>';
Steps To ReproduceSee http://ci.openbravo.com/view/try/job/try-api/7262/consoleFull [^]
TagsApproved
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0040906 closedalostale platform: review FK columns to set which ones shouldn't generate one-to-many property in parent entity 
caused by feature request 00412283.0PR19Q4 closedvmromanos One-to-many clean up of existing columns (Functional) 

-  Notes
(0113170)
hgbot (developer)
2019-07-04 10:10

 Repository: erp/devel/api-checks
Changeset: 5beecb7e9aa7e11a85967e17073146b47d4317e3
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Jul 04 10:10:14 2019 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/5beecb7e9aa7e11a85967e17073146b47d4317e3 [^]

Fixed 41227 41228: One-to-many Functional cleanup

---
M java/reference/java.japi.gz
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml
M model/modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_COLUMN.xml
M model/src-db/database/sourcedata/AD_COLUMN.xml
---
(0113215)
Sandrahuguet (developer)
2019-07-08 15:15
edited on: 2019-07-08 15:19

 Repository: erp/devel/api-checks
Changeset: 1875dc350bf3
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Jul 04 10:10:14 2019 +0200
URL: https://code.openbravo.com/erp/devel/api-checks/rev/1875dc350bf3 [^]

Related to 41227 41228: One-to-many cleanup (Functional) finetune

Reverted back relationship beetween Order and Quotation list because it is used by a JUnit tests,
and on the other hand it might makes sense from a Functional POV

---
model/src-db/database/sourcedata/AD_COLUMN.xml
---
(0113216)
Sandrahuguet (developer)
2019-07-08 15:23

 Repository: erp/devel/api-checks
Changeset: 1875dc350bf3
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Jul 08 15:10:14 2019 +0200
URL: https://code.openbravo.com/erp/devel/api-checks/rev/2533a6a6161c [^]

Related to 41227 41228: Removed Costing related columns

---
java/reference/java.japi.gz
model/src-db/database/sourcedata/AD_COLUMN.xml
---
(0113218)
Sandrahuguet (developer)
2019-07-08 15:27

 verified

- Issue History
Date Modified Username Field Change
2019-07-02 13:06 vmromanos New Issue
2019-07-02 13:06 vmromanos Assigned To => vmromanos
2019-07-02 13:06 vmromanos Modules => Core
2019-07-02 13:06 vmromanos Triggers an Emergency Pack => No
2019-07-02 13:06 vmromanos Assigned To vmromanos => dmitry_mezentsev
2019-07-02 13:14 vmromanos Relationship added caused by 0041228
2019-07-02 19:59 dmitry_mezentsev Tag Attached: Approved
2019-07-04 10:07 vmromanos Status new => scheduled
2019-07-04 10:07 vmromanos Assigned To dmitry_mezentsev => vmromanos
2019-07-04 10:09 vmromanos Description Updated View Revisions
2019-07-04 10:10 hgbot Checkin
2019-07-04 10:10 hgbot Note Added: 0113170
2019-07-04 10:10 hgbot Status scheduled => resolved
2019-07-04 10:10 hgbot Resolution open => fixed
2019-07-04 10:10 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/5beecb7e9aa7e11a85967e17073146b47d4317e3 [^]
2019-07-04 10:18 vmromanos Description Updated View Revisions
2019-07-04 16:36 vmromanos Description Updated View Revisions
2019-07-05 09:12 vmromanos Review Assigned To => Sandrahuguet
2019-07-08 15:15 Sandrahuguet Note Added: 0113215
2019-07-08 15:18 Sandrahuguet Note Edited: 0113215 View Revisions
2019-07-08 15:19 Sandrahuguet Note Edited: 0113215 View Revisions
2019-07-08 15:19 Sandrahuguet Note Edited: 0113215 View Revisions
2019-07-08 15:19 Sandrahuguet Note Edited: 0113215 View Revisions
2019-07-08 15:23 Sandrahuguet Note Added: 0113216
2019-07-08 15:27 Sandrahuguet Note Added: 0113218
2019-07-08 15:27 Sandrahuguet Status resolved => closed
2019-07-08 15:27 Sandrahuguet Fixed in Version => 3.0PR19Q4
2019-07-23 15:45 vmromanos Relationship added related to 0040906

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker