Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041227Openbravo ERPZ. Otherspublic2019-07-02 13:062019-07-23 15:45
Reportervmromanos 
Assigned Tovmromanos 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q4Fixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041227: API Change: One-to-many cleanup (Functional team)
DescriptionDue to the one-to-many cleanup project, many relationships between entities have been removed from the Java model classes generated by DAL. You can see details about the affected columns at https://docs.google.com/spreadsheets/d/1hdwjGM4_3TJ-9Bcylh_w_MM54_1T_cUlicaPfEyH1MQ [^]

This is done by setting the AD_Column.is_child_property_in_parent to 'N' for the selected columns.

This action creates an expected API change that widely affects many Openbravo 3 classes. More details: http://ci.openbravo.com/view/try/job/try-api/7262/consoleFull [^]


The approach we have followed for the cleanup is:
1. to keep always any relationship already consumed by internal or external modules (any module published in the forge).
2. for the rest of the relationships, try to be aggressive and remove as many as possible, leaving only the relationships that clearly make sense from a Functional POV and that are safe from a Performance POV, ie which don't load too many objects in memory on a standard environment.


Due to the above approach the API change risk could be classified as "high". However, in case of any external module not currently published in the forge is affected by this change, the developer can easily revert back to the previous API by running the following SQL and exporting the result to a template:

update ad_column set is_child_property_in_parent = 'Y' where ad_column_id = '<AffectedColumnID>';
Steps To ReproduceSee http://ci.openbravo.com/view/try/job/try-api/7262/consoleFull [^]
Proposed Solution
Additional Information
TagsApproved
Relationships
related to design defect 0040906 closed alostale platform: review FK columns to set which ones shouldn't generate one-to-many property in parent entity 
caused by feature request 00412283.0PR19Q4 closed vmromanos One-to-many clean up of existing columns (Functional) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-02 13:06vmromanosNew Issue
2019-07-02 13:06vmromanosAssigned To => vmromanos
2019-07-02 13:06vmromanosModules => Core
2019-07-02 13:06vmromanosTriggers an Emergency Pack => No
2019-07-02 13:06vmromanosAssigned Tovmromanos => dmitry_mezentsev
2019-07-02 13:14vmromanosRelationship addedcaused by 0041228
2019-07-02 19:59dmitry_mezentsevTag Attached: Approved
2019-07-04 10:07vmromanosStatusnew => scheduled
2019-07-04 10:07vmromanosAssigned Todmitry_mezentsev => vmromanos
2019-07-04 10:09vmromanosDescription Updatedbug_revision_view_page.php?rev_id=19033#r19033
2019-07-04 10:10hgbotCheckin
2019-07-04 10:10hgbotNote Added: 0113170
2019-07-04 10:10hgbotStatusscheduled => resolved
2019-07-04 10:10hgbotResolutionopen => fixed
2019-07-04 10:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/5beecb7e9aa7e11a85967e17073146b47d4317e3 [^]
2019-07-04 10:18vmromanosDescription Updatedbug_revision_view_page.php?rev_id=19034#r19034
2019-07-04 16:36vmromanosDescription Updatedbug_revision_view_page.php?rev_id=19037#r19037
2019-07-05 09:12vmromanosReview Assigned To => Sandrahuguet
2019-07-08 15:15SandrahuguetNote Added: 0113215
2019-07-08 15:18SandrahuguetNote Edited: 0113215bug_revision_view_page.php?bugnote_id=0113215#r19061
2019-07-08 15:19SandrahuguetNote Edited: 0113215bug_revision_view_page.php?bugnote_id=0113215#r19062
2019-07-08 15:19SandrahuguetNote Edited: 0113215bug_revision_view_page.php?bugnote_id=0113215#r19063
2019-07-08 15:19SandrahuguetNote Edited: 0113215bug_revision_view_page.php?bugnote_id=0113215#r19064
2019-07-08 15:23SandrahuguetNote Added: 0113216
2019-07-08 15:27SandrahuguetNote Added: 0113218
2019-07-08 15:27SandrahuguetStatusresolved => closed
2019-07-08 15:27SandrahuguetFixed in Version => 3.0PR19Q4
2019-07-23 15:45vmromanosRelationship addedrelated to 0040906

Notes
(0113170)
hgbot   
2019-07-04 10:10   
Repository: erp/devel/api-checks
Changeset: 5beecb7e9aa7e11a85967e17073146b47d4317e3
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Jul 04 10:10:14 2019 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/5beecb7e9aa7e11a85967e17073146b47d4317e3 [^]

Fixed 41227 41228: One-to-many Functional cleanup

---
M java/reference/java.japi.gz
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml
M model/modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_COLUMN.xml
M model/src-db/database/sourcedata/AD_COLUMN.xml
---
(0113215)
Sandrahuguet   
2019-07-08 15:15   
(edited on: 2019-07-08 15:19)
Repository: erp/devel/api-checks
Changeset: 1875dc350bf3
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Jul 04 10:10:14 2019 +0200
URL: https://code.openbravo.com/erp/devel/api-checks/rev/1875dc350bf3 [^]

Related to 41227 41228: One-to-many cleanup (Functional) finetune

Reverted back relationship beetween Order and Quotation list because it is used by a JUnit tests,
and on the other hand it might makes sense from a Functional POV

---
model/src-db/database/sourcedata/AD_COLUMN.xml
---
(0113216)
Sandrahuguet   
2019-07-08 15:23   
Repository: erp/devel/api-checks
Changeset: 1875dc350bf3
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Jul 08 15:10:14 2019 +0200
URL: https://code.openbravo.com/erp/devel/api-checks/rev/2533a6a6161c [^]

Related to 41227 41228: Removed Costing related columns

---
java/reference/java.japi.gz
model/src-db/database/sourcedata/AD_COLUMN.xml
---
(0113218)
Sandrahuguet   
2019-07-08 15:27   
verified