Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0041128
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSmajoralways2019-06-17 13:292019-07-15 08:57
ReporterguillermogilView Statuspublic 
Assigned Toguilleaer 
PriorityimmediateResolutionfixedFixed in VersionRR19Q1.2
StatusclosedFix in branchFixed in SCM revision4d42fec1c153
ProjectionnoneETAnoneTarget VersionRR19Q1.2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerGold
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2019-12-16
Regression introduced in releaseRR19Q1
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/331aa4146a49 [^]
Triggers an Emergency PackNo
Summary

0041128: QtyDelivered has changed its representation on DB

DescriptionQtyDelivered has changed its representation on DB and now is saved with decimal values and before 19Q1 it did not have decimal values at database level.
As an example:
On 18Q4 qtyDelivered at DB level was 1
On 19Q1 qtyDelivered at DB level is 1.0

As the representation of the value have changed some third party integration could be broken.

It will happen with every column saved with a "BigDecimal.valueof"
Previously it was a "new BigDecimal"

It will be needed to check OrderLoader to review all the properties that have changed.
We've identified QtyDelivered column but it is needed to check for more.
Steps To ReproduceCreate a ticket on WebPOS and check QtyDelivered column.
Proposed SolutionModify:
BigDecimal.valueOf(jsonOrderLine.getDouble("XXX"))

To:
new BigDecimal(jsonOrderLine.getString("XXX"))

See diff attached.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0041103 closedguilleaer QtyDelivered has changed its representation on DB 

-  Notes
(0112898)
hgbot (developer)
2019-06-19 16:09

 Repository: retail/backports/3.0RR19Q1.2/org.openbravo.retail.posterminal
Changeset: 4d42fec1c1534ef9b4b8a726601a3ca555331dde
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Jun 19 16:09:36 2019 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR19Q1.2/org.openbravo.retail.posterminal/rev/4d42fec1c1534ef9b4b8a726601a3ca555331dde [^]

fixed Issue 41128: Use new instead of value of for qtyDelivered

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0112901)
hgbot (developer)
2019-06-19 16:13

 Repository: retail/backports/3.0RR19Q1.2/pi-mobile
Changeset: b3a0611648539264af58d07ca41612b9c096063e
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Jun 19 16:12:58 2019 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR19Q1.2/pi-mobile/rev/b3a0611648539264af58d07ca41612b9c096063e [^]

Related to issue 41128: Adapt test

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/productlockeddiscontinued/VerifyProductDiscontinuedWithoutStock.java
---
(0113347)
hgbot (developer)
2019-07-15 08:57

 Repository: tools/automation/pi-mobile
Changeset: b3a0611648539264af58d07ca41612b9c096063e
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Jun 19 16:12:58 2019 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b3a0611648539264af58d07ca41612b9c096063e [^]

Related to issue 41128: Adapt test

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/productlockeddiscontinued/VerifyProductDiscontinuedWithoutStock.java
---

- Issue History
Date Modified Username Field Change
2019-06-19 16:05 migueldejuana Type defect => backport
2019-06-19 16:05 migueldejuana Target Version => RR19Q1.2
2019-06-19 16:09 hgbot Checkin
2019-06-19 16:09 hgbot Note Added: 0112898
2019-06-19 16:09 hgbot Status scheduled => resolved
2019-06-19 16:09 hgbot Resolution open => fixed
2019-06-19 16:09 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6bc44e82d318c0563a74a88db91941db7154bbb5 [^] => http://code.openbravo.com/retail/backports/3.0RR19Q1.2/org.openbravo.retail.posterminal/rev/4d42fec1c1534ef9b4b8a726601a3ca555331dde [^]
2019-06-19 16:13 hgbot Checkin
2019-06-19 16:13 hgbot Note Added: 0112901
2019-07-08 13:29 guilleaer Review Assigned To => guilleaer
2019-07-08 13:29 guilleaer Status resolved => closed
2019-07-08 13:29 guilleaer Fixed in Version => RR19Q1.2
2019-07-15 08:57 hgbot Checkin
2019-07-15 08:57 hgbot Note Added: 0113347

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker