Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0041103
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2019-06-17 13:292019-06-19 16:13
ReporterguillermogilView Statuspublic 
Assigned Toguilleaer 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision6bc44e82d318
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomigueldejuana
Regression levelProduction - Confirmed Stable
Regression date2019-12-16
Regression introduced in releaseRR19Q1
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/331aa4146a49 [^]
Triggers an Emergency PackNo
Summary

0041103: QtyDelivered has changed its representation on DB

DescriptionQtyDelivered has changed its representation on DB and now is saved with decimal values and before 19Q1 it did not have decimal values at database level.
As an example:
On 18Q4 qtyDelivered at DB level was 1
On 19Q1 qtyDelivered at DB level is 1.0

As the representation of the value have changed some third party integration could be broken.

It will happen with every column saved with a "BigDecimal.valueof"
Previously it was a "new BigDecimal"

It will be needed to check OrderLoader to review all the properties that have changed.
We've identified QtyDelivered column but it is needed to check for more.
Steps To ReproduceCreate a ticket on WebPOS and check QtyDelivered column.
Proposed SolutionModify:
BigDecimal.valueOf(jsonOrderLine.getDouble("XXX"))

To:
new BigDecimal(jsonOrderLine.getString("XXX"))

See diff attached.
TagsNo tags attached.
Attached Filesdiff file icon 41103.diff [^] (1,206 bytes) 2019-06-17 15:06 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0041127RR19Q2.1 closedguilleaer QtyDelivered has changed its representation on DB 
depends on backport 0041128RR19Q1.2 closedguilleaer QtyDelivered has changed its representation on DB 

-  Notes
(0112875)
hgbot (developer)
2019-06-18 23:26

 Repository: tools/automation/pi-mobile
Changeset: 5e69713588425dbd81e43254a1c25da141882e35
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Jun 18 12:59:04 2019 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/5e69713588425dbd81e43254a1c25da141882e35 [^]

Related to issue 41103: Adapt test

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/productlockeddiscontinued/VerifyProductDiscontinuedWithoutStock.java
---
(0112876)
hgbot (developer)
2019-06-18 23:26

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6bc44e82d318c0563a74a88db91941db7154bbb5
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Jun 18 12:52:08 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6bc44e82d318c0563a74a88db91941db7154bbb5 [^]

fixed Issue 41103: Use new instead of value of for qtyDelivered

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0112902)
migueldejuana (developer)
2019-06-19 16:13

 Tested and reviewed

- Issue History
Date Modified Username Field Change
2019-06-17 13:29 guillermogil New Issue
2019-06-17 13:29 guillermogil Assigned To => Retail
2019-06-17 13:29 guillermogil Resolution time => 1562364000
2019-06-17 13:29 guillermogil Regression level => Production - Confirmed Stable
2019-06-17 13:29 guillermogil Triggers an Emergency Pack => No
2019-06-17 13:29 guillermogil Description Updated View Revisions
2019-06-17 13:33 guillermogil Description Updated View Revisions
2019-06-17 13:33 guillermogil Proposed Solution updated
2019-06-17 13:37 guillermogil Description Updated View Revisions
2019-06-17 13:37 guillermogil Description Updated View Revisions
2019-06-17 13:39 guillermogil Regression date => 2019-12-16
2019-06-17 13:39 guillermogil Regression introduced in release => RR19Q1
2019-06-17 13:39 guillermogil Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/331aa4146a49 [^]
2019-06-17 13:39 guillermogil Description Updated View Revisions
2019-06-17 13:39 guillermogil Proposed Solution updated
2019-06-17 13:40 guillermogil Summary QtyDelivered is saved with decimal => QtyDelivered is saved with decimal values
2019-06-17 13:51 guillermogil Description Updated View Revisions
2019-06-17 13:57 guillermogil Summary QtyDelivered is saved with decimal values => QtyDelivered has changed its representation on DB
2019-06-17 14:37 guillermogil Description Updated View Revisions
2019-06-17 14:39 guillermogil Description Updated View Revisions
2019-06-17 14:52 guillermogil Description Updated View Revisions
2019-06-17 15:06 guillermogil File Added: 41103.diff
2019-06-17 15:06 guillermogil Proposed Solution updated
2019-06-17 16:03 guillermogil Description Updated View Revisions
2019-06-18 13:38 guilleaer Assigned To Retail => guilleaer
2019-06-18 23:26 hgbot Checkin
2019-06-18 23:26 hgbot Note Added: 0112875
2019-06-18 23:26 hgbot Checkin
2019-06-18 23:26 hgbot Note Added: 0112876
2019-06-18 23:26 hgbot Status new => resolved
2019-06-18 23:26 hgbot Resolution open => fixed
2019-06-18 23:26 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6bc44e82d318c0563a74a88db91941db7154bbb5 [^]
2019-06-19 16:05 migueldejuana Status resolved => new
2019-06-19 16:05 migueldejuana Resolution fixed => open
2019-06-19 16:05 migueldejuana Status new => scheduled
2019-06-19 16:13 migueldejuana Status scheduled => resolved
2019-06-19 16:13 migueldejuana Resolution open => fixed
2019-06-19 16:13 migueldejuana Review Assigned To => migueldejuana
2019-06-19 16:13 migueldejuana Note Added: 0112902
2019-06-19 16:13 migueldejuana Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker