Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041103Retail ModulesWeb POSpublic2019-06-17 13:292019-06-19 16:13
Reporterguillermogil 
Assigned Toguilleaer 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2019-12-16
Regression introduced in releaseRR19Q1
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/331aa4146a49 [^]
Triggers an Emergency PackNo
Summary0041103: QtyDelivered has changed its representation on DB
DescriptionQtyDelivered has changed its representation on DB and now is saved with decimal values and before 19Q1 it did not have decimal values at database level.
As an example:
On 18Q4 qtyDelivered at DB level was 1
On 19Q1 qtyDelivered at DB level is 1.0

As the representation of the value have changed some third party integration could be broken.

It will happen with every column saved with a "BigDecimal.valueof"
Previously it was a "new BigDecimal"

It will be needed to check OrderLoader to review all the properties that have changed.
We've identified QtyDelivered column but it is needed to check for more.
Steps To ReproduceCreate a ticket on WebPOS and check QtyDelivered column.
Proposed SolutionModify:
BigDecimal.valueOf(jsonOrderLine.getDouble("XXX"))

To:
new BigDecimal(jsonOrderLine.getString("XXX"))

See diff attached.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0041127RR19Q2.1 closed guilleaer QtyDelivered has changed its representation on DB 
depends on backport 0041128RR19Q1.2 closed guilleaer QtyDelivered has changed its representation on DB 
Attached Filesdiff 41103.diff (1,206) 2019-06-17 15:06
https://issues.openbravo.com/file_download.php?file_id=13022&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-06-17 13:29guillermogilNew Issue
2019-06-17 13:29guillermogilAssigned To => Retail
2019-06-17 13:29guillermogilResolution time => 1562364000
2019-06-17 13:29guillermogilRegression level => Production - Confirmed Stable
2019-06-17 13:29guillermogilTriggers an Emergency Pack => No
2019-06-17 13:29guillermogilDescription Updatedbug_revision_view_page.php?rev_id=18933#r18933
2019-06-17 13:33guillermogilDescription Updatedbug_revision_view_page.php?rev_id=18934#r18934
2019-06-17 13:33guillermogilProposed Solution updated
2019-06-17 13:37guillermogilDescription Updatedbug_revision_view_page.php?rev_id=18935#r18935
2019-06-17 13:37guillermogilDescription Updatedbug_revision_view_page.php?rev_id=18936#r18936
2019-06-17 13:39guillermogilRegression date => 2019-12-16
2019-06-17 13:39guillermogilRegression introduced in release => RR19Q1
2019-06-17 13:39guillermogilRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/331aa4146a49 [^]
2019-06-17 13:39guillermogilDescription Updatedbug_revision_view_page.php?rev_id=18937#r18937
2019-06-17 13:39guillermogilProposed Solution updated
2019-06-17 13:40guillermogilSummaryQtyDelivered is saved with decimal => QtyDelivered is saved with decimal values
2019-06-17 13:51guillermogilDescription Updatedbug_revision_view_page.php?rev_id=18938#r18938
2019-06-17 13:57guillermogilSummaryQtyDelivered is saved with decimal values => QtyDelivered has changed its representation on DB
2019-06-17 14:37guillermogilDescription Updatedbug_revision_view_page.php?rev_id=18941#r18941
2019-06-17 14:39guillermogilDescription Updatedbug_revision_view_page.php?rev_id=18942#r18942
2019-06-17 14:52guillermogilDescription Updatedbug_revision_view_page.php?rev_id=18943#r18943
2019-06-17 15:06guillermogilFile Added: 41103.diff
2019-06-17 15:06guillermogilProposed Solution updated
2019-06-17 16:03guillermogilDescription Updatedbug_revision_view_page.php?rev_id=18944#r18944
2019-06-18 13:38guilleaerAssigned ToRetail => guilleaer
2019-06-18 23:26hgbotCheckin
2019-06-18 23:26hgbotNote Added: 0112875
2019-06-18 23:26hgbotCheckin
2019-06-18 23:26hgbotNote Added: 0112876
2019-06-18 23:26hgbotStatusnew => resolved
2019-06-18 23:26hgbotResolutionopen => fixed
2019-06-18 23:26hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6bc44e82d318c0563a74a88db91941db7154bbb5 [^]
2019-06-19 16:05migueldejuanaStatusresolved => new
2019-06-19 16:05migueldejuanaResolutionfixed => open
2019-06-19 16:05migueldejuanaStatusnew => scheduled
2019-06-19 16:13migueldejuanaStatusscheduled => resolved
2019-06-19 16:13migueldejuanaResolutionopen => fixed
2019-06-19 16:13migueldejuanaReview Assigned To => migueldejuana
2019-06-19 16:13migueldejuanaNote Added: 0112902
2019-06-19 16:13migueldejuanaStatusresolved => closed

Notes
(0112875)
hgbot   
2019-06-18 23:26   
Repository: tools/automation/pi-mobile
Changeset: 5e69713588425dbd81e43254a1c25da141882e35
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Jun 18 12:59:04 2019 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/5e69713588425dbd81e43254a1c25da141882e35 [^]

Related to issue 41103: Adapt test

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/productlockeddiscontinued/VerifyProductDiscontinuedWithoutStock.java
---
(0112876)
hgbot   
2019-06-18 23:26   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6bc44e82d318c0563a74a88db91941db7154bbb5
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Jun 18 12:52:08 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6bc44e82d318c0563a74a88db91941db7154bbb5 [^]

fixed Issue 41103: Use new instead of value of for qtyDelivered

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0112902)
migueldejuana   
2019-06-19 16:13   
Tested and reviewed