0041128: QtyDelivered has changed its representation on DB

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0041128

Retail Modules

Web POS

public

2019-06-17 13:29

2019-07-15 08:57

Reporter

guillermogil

Assigned To

guilleaer

Priority

immediate

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR19Q1.2

Fixed in Version

RR19Q1.2

Merge Request Status

Review Assigned To

guilleaer

OBNetwork customer

Gold

Support ticket

Regression level

Production - Confirmed Stable

Regression date

2019-12-16

Regression introduced in release

RR19Q1

Regression introduced by commit

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/331aa4146a49 [^]

Triggers an Emergency Pack

Summary

0041128: QtyDelivered has changed its representation on DB

Description

QtyDelivered has changed its representation on DB and now is saved with decimal values and before 19Q1 it did not have decimal values at database level.
As an example:
On 18Q4 qtyDelivered at DB level was 1
On 19Q1 qtyDelivered at DB level is 1.0

As the representation of the value have changed some third party integration could be broken.

It will happen with every column saved with a "BigDecimal.valueof"
Previously it was a "new BigDecimal"

It will be needed to check OrderLoader to review all the properties that have changed.
We've identified QtyDelivered column but it is needed to check for more.

Steps To Reproduce

Create a ticket on WebPOS and check QtyDelivered column.

Proposed Solution

Modify:
BigDecimal.valueOf(jsonOrderLine.getDouble("XXX"))

To:
new BigDecimal(jsonOrderLine.getString("XXX"))

See diff attached.

Additional Information