Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0040653 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Modules] Authorize.net Integration | minor | have not tried | 2019-04-23 10:26 | 2019-04-23 16:49 | |||
| Reporter | caristu | View Status | public | |||||
| Assigned To | caristu | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 934911a94d2a | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | Sandrahuguet | |||||||
| Regression introduced in release | ||||||||
| Summary | 0040653: Unnecessary @SuppressWarnings("unchecked") after Hibernate upgrade | |||||||
| Description | After the Hibernate upgrade to version 5.4.2 (0040552) it is no longer needed to suppress several warnings in SubscriptionActionHandlerUtilData class. For this reason, several eclipse warnings are being displayed (see attached log) | |||||||
| Steps To Reproduce | 1) Update pi to a revision equal or higher than https://code.openbravo.com/erp/devel/pi/rev/bdd63e1a834142c97bca4bee8ad1f5afbfadaafd [^] 2) Install authorize.net module. 3) Open Eclipse. Several warnings appear in SubscriptionActionHandlerUtilData. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  eclipseWarns.txt [^] (1,939 bytes) 2019-04-23 10:26 [Show Content]
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||
|
|||||||||
 Relationships |
|
Notes |
|
|
(0111230) hgbot (developer) 2019-04-23 11:15 |
Repository: erp/pmods/org.openbravo.authorize.net Changeset: 39908e85aa3fa0d5e5aa7adebfc5eef2ea832b4d Author: Carlos Aristu <carlos.aristu <at> openbravo.com> Date: Tue Apr 23 10:56:50 2019 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.authorize.net/rev/39908e85aa3fa0d5e5aa7adebfc5eef2ea832b4d [^] related to issue 40653: apply new formatting + update copyright year --- M src/org/openbravo/authorize/net/actionhandler/SubscriptionActionHandlerUtilData.java --- |
|
(0111231) hgbot (developer) 2019-04-23 11:15 |
Repository: erp/pmods/org.openbravo.authorize.net Changeset: 934911a94d2a78f053aeb892ea3eedceeb063d6b Author: Carlos Aristu <carlos.aristu <at> openbravo.com> Date: Tue Apr 23 11:03:40 2019 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.authorize.net/rev/934911a94d2a78f053aeb892ea3eedceeb063d6b [^] fixes issue 40653: Remove unnecessary @SuppressWarnings("unchecked") As part of the change introduced with the Hibernate upgrade to version 5.4.2[1], OBCriteria and OBQuery support method chaining[2]. In this particular case, after invoking "setMaxResults()" in an OBCriteria, now the OBCriteria itself is being returned. Thus, the @SuppressWarnings("unchecked") is no longer needed because the "list()" method of OBCriteria does not require it. [1] https://issues.openbravo.com/view.php?id=40552 [^] [2] https://issues.openbravo.com/view.php?id=40614 [^] --- M src/org/openbravo/authorize/net/actionhandler/SubscriptionActionHandlerUtilData.java --- |
|
(0111242) Sandrahuguet (developer) 2019-04-23 16:49 |
Verified |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2019-04-23 10:26 | caristu | New Issue | |
| 2019-04-23 10:26 | caristu | Assigned To | => Triage Finance |
| 2019-04-23 10:26 | caristu | File Added: eclipseWarns.txt | |
| 2019-04-23 10:26 | caristu | Assigned To | Triage Finance => caristu |
| 2019-04-23 10:26 | caristu | Relationship added | caused by 0040552 |
| 2019-04-23 10:30 | caristu | Review Assigned To | => Sandrahuguet |
| 2019-04-23 11:15 | hgbot | Checkin | |
| 2019-04-23 11:15 | hgbot | Note Added: 0111230 | |
| 2019-04-23 11:15 | hgbot | Checkin | |
| 2019-04-23 11:15 | hgbot | Note Added: 0111231 | |
| 2019-04-23 11:15 | hgbot | Status | new => resolved |
| 2019-04-23 11:15 | hgbot | Resolution | open => fixed |
| 2019-04-23 11:15 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.authorize.net/rev/934911a94d2a78f053aeb892ea3eedceeb063d6b [^] |
| 2019-04-23 16:49 | Sandrahuguet | Note Added: 0111242 | |
| 2019-04-23 16:49 | Sandrahuguet | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |