Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040653ModulesAuthorize.net Integrationpublic2019-04-23 10:262019-04-23 16:49
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned ToSandrahuguet
Support ticket
OBNetwork customer
Regression introduced in release
Summary0040653: Unnecessary @SuppressWarnings("unchecked") after Hibernate upgrade
DescriptionAfter the Hibernate upgrade to version 5.4.2 (0040552) it is no longer needed to suppress several warnings in SubscriptionActionHandlerUtilData class.

For this reason, several eclipse warnings are being displayed (see attached log)
Steps To Reproduce1) Update pi to a revision equal or higher than https://code.openbravo.com/erp/devel/pi/rev/bdd63e1a834142c97bca4bee8ad1f5afbfadaafd [^]

2) Install authorize.net module.

3) Open Eclipse. Several warnings appear in SubscriptionActionHandlerUtilData.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by feature request 0040552 closed caristu Openbravo ERP upgrade hibernate to version 5.4 
Attached Filestxt eclipseWarns.txt (1,939) 2019-04-23 10:26
https://issues.openbravo.com/file_download.php?file_id=12878&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-04-23 10:26caristuNew Issue
2019-04-23 10:26caristuAssigned To => Triage Finance
2019-04-23 10:26caristuFile Added: eclipseWarns.txt
2019-04-23 10:26caristuAssigned ToTriage Finance => caristu
2019-04-23 10:26caristuRelationship addedcaused by 0040552
2019-04-23 10:30caristuReview Assigned To => Sandrahuguet
2019-04-23 11:15hgbotCheckin
2019-04-23 11:15hgbotNote Added: 0111230
2019-04-23 11:15hgbotCheckin
2019-04-23 11:15hgbotNote Added: 0111231
2019-04-23 11:15hgbotStatusnew => resolved
2019-04-23 11:15hgbotResolutionopen => fixed
2019-04-23 11:15hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.authorize.net/rev/934911a94d2a78f053aeb892ea3eedceeb063d6b [^]
2019-04-23 16:49SandrahuguetNote Added: 0111242
2019-04-23 16:49SandrahuguetStatusresolved => closed

Notes
(0111230)
hgbot   
2019-04-23 11:15   
Repository: erp/pmods/org.openbravo.authorize.net
Changeset: 39908e85aa3fa0d5e5aa7adebfc5eef2ea832b4d
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Apr 23 10:56:50 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.authorize.net/rev/39908e85aa3fa0d5e5aa7adebfc5eef2ea832b4d [^]

related to issue 40653: apply new formatting + update copyright year

---
M src/org/openbravo/authorize/net/actionhandler/SubscriptionActionHandlerUtilData.java
---
(0111231)
hgbot   
2019-04-23 11:15   
Repository: erp/pmods/org.openbravo.authorize.net
Changeset: 934911a94d2a78f053aeb892ea3eedceeb063d6b
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Apr 23 11:03:40 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.authorize.net/rev/934911a94d2a78f053aeb892ea3eedceeb063d6b [^]

fixes issue 40653: Remove unnecessary @SuppressWarnings("unchecked")

  As part of the change introduced with the Hibernate upgrade to version 5.4.2[1], OBCriteria and OBQuery support method chaining[2].

  In this particular case, after invoking "setMaxResults()" in an OBCriteria, now the OBCriteria itself is being returned. Thus, the @SuppressWarnings("unchecked") is no longer needed because the "list()" method of OBCriteria does not require it.

  [1] https://issues.openbravo.com/view.php?id=40552 [^]
  [2] https://issues.openbravo.com/view.php?id=40614 [^]

---
M src/org/openbravo/authorize/net/actionhandler/SubscriptionActionHandlerUtilData.java
---
(0111242)
Sandrahuguet   
2019-04-23 16:49   
Verified