Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0040096
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Retail Modules] StoreServermajorhave not tried2019-01-31 22:312019-02-15 11:05
ReportermtaalView Statuspublic 
Assigned Tomigueldejuana 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision0fd177011896
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomtaal
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0040096: Source verson check is not done for store server, add it to the central server login

DescriptionThe source version check [1] with the if statement is never executed for a webapp loaded from central but talking to the store server. This in itself is fine as the code maybe loaded from central while the login happens on the store server.

In case of running webpos in multi-server always check the source version against the central server if available.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/web/org.openbravo.mobile.core/source/model/ob-terminal-model.js#l2189 [^]
Steps To ReproduceUse multi-server
Load the web app from central, see that sourceversion check is never done at login
Proposed SolutionAdd the source version check here [1]
To enable it let the ContextInformation request/service also return the sourceversion.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/web/org.openbravo.mobile.core/source/utils/ob-utilities.js#l1285 [^]
TagsNo tags attached.
Attached Filesdiff file icon sourceversion_but.diff [^] (4,186 bytes) 2019-02-14 17:49 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0037159 closedmarvintm new js file is not sent to terminal when login is done. Refresh browser is required 
related to defect 0041069 closedmtaal SourceCode not updated after a deploy if the StoreServer is offline 

-  Notes
(0109849)
hgbot (developer)
2019-02-15 07:56

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 0fd177011896adb9db4117dbe6c1e30c2bcd6e74
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Feb 15 07:56:00 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0fd177011896adb9db4117dbe6c1e30c2bcd6e74 [^]

Fixed issue 0040096: Source verson check is not done for store server, add it to the central server login

- Do not use Store Server sourceVersion to know if code changed or not
- Evaluate sourceVersion always, not only for single server

---
M src/org/openbravo/mobile/core/login/MobileCoreLoginHandler.java
M src/org/openbravo/mobile/core/process/JSONProcessSimple.java
M web/org.openbravo.mobile.core/source/data/ob-datasource.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0109857)
mtaal (manager)
2019-02-15 11:05

reviewed and tested

- Issue History
Date Modified Username Field Change
2019-01-31 22:31 mtaal New Issue
2019-01-31 22:31 mtaal Assigned To => migueldejuana
2019-01-31 22:31 mtaal Triggers an Emergency Pack => No
2019-01-31 22:32 mtaal Relationship added related to 0037159
2019-02-05 08:54 guillermogil Resolution time => 1550703600
2019-02-05 09:01 guillermogil Summary Source verson check is not done for store serer, add it to the central server login => Source verson check is not done for store server, add it to the central server login
2019-02-14 17:49 mtaal File Added: sourceversion_but.diff
2019-02-14 17:49 mtaal Review Assigned To => mtaal
2019-02-15 07:56 hgbot Checkin
2019-02-15 07:56 hgbot Note Added: 0109849
2019-02-15 07:56 hgbot Status new => resolved
2019-02-15 07:56 hgbot Resolution open => fixed
2019-02-15 07:56 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0fd177011896adb9db4117dbe6c1e30c2bcd6e74 [^]
2019-02-15 11:05 mtaal Note Added: 0109857
2019-02-15 11:05 mtaal Status resolved => closed
2019-06-12 23:04 mtaal Relationship added related to 0041069


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker