Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0040096 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
design defect | [Retail Modules] StoreServer | major | have not tried | 2019-01-31 22:31 | 2019-02-15 11:05 | |||
Reporter | mtaal | View Status | public | |||||
Assigned To | migueldejuana | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | 0fd177011896 | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | mtaal | |||||||
OBNetwork customer | Gold | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0040096: Source verson check is not done for store server, add it to the central server login | |||||||
Description | The source version check [1] with the if statement is never executed for a webapp loaded from central but talking to the store server. This in itself is fine as the code maybe loaded from central while the login happens on the store server. In case of running webpos in multi-server always check the source version against the central server if available. [1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/web/org.openbravo.mobile.core/source/model/ob-terminal-model.js#l2189 [^] | |||||||
Steps To Reproduce | Use multi-server Load the web app from central, see that sourceversion check is never done at login | |||||||
Proposed Solution | Add the source version check here [1] To enable it let the ContextInformation request/service also return the sourceversion. [1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/web/org.openbravo.mobile.core/source/utils/ob-utilities.js#l1285 [^] | |||||||
Tags | No tags attached. | |||||||
Attached Files | ![]() | |||||||
![]() |
|||||||||||||||
|
![]() |
|
(0109849) hgbot (developer) 2019-02-15 07:56 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 0fd177011896adb9db4117dbe6c1e30c2bcd6e74 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Fri Feb 15 07:56:00 2019 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0fd177011896adb9db4117dbe6c1e30c2bcd6e74 [^] Fixed issue 0040096: Source verson check is not done for store server, add it to the central server login - Do not use Store Server sourceVersion to know if code changed or not - Evaluate sourceVersion always, not only for single server --- M src/org/openbravo/mobile/core/login/MobileCoreLoginHandler.java M src/org/openbravo/mobile/core/process/JSONProcessSimple.java M web/org.openbravo.mobile.core/source/data/ob-datasource.js M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js --- |
(0109857) mtaal (viewer) 2019-02-15 11:05 |
reviewed and tested |
![]() |
|||
Date Modified | Username | Field | Change |
2019-01-31 22:31 | mtaal | New Issue | |
2019-01-31 22:31 | mtaal | Assigned To | => migueldejuana |
2019-01-31 22:31 | mtaal | OBNetwork customer | => No |
2019-01-31 22:31 | mtaal | Triggers an Emergency Pack | => No |
2019-01-31 22:32 | mtaal | Relationship added | related to 0037159 |
2019-02-05 08:54 | guillermogil | OBNetwork customer | No => Gold |
2019-02-05 08:54 | guillermogil | Resolution time | => 1550703600 |
2019-02-05 09:01 | guillermogil | Summary | Source verson check is not done for store serer, add it to the central server login => Source verson check is not done for store server, add it to the central server login |
2019-02-14 17:49 | mtaal | File Added: sourceversion_but.diff | |
2019-02-14 17:49 | mtaal | Review Assigned To | => mtaal |
2019-02-15 07:56 | hgbot | Checkin | |
2019-02-15 07:56 | hgbot | Note Added: 0109849 | |
2019-02-15 07:56 | hgbot | Status | new => resolved |
2019-02-15 07:56 | hgbot | Resolution | open => fixed |
2019-02-15 07:56 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0fd177011896adb9db4117dbe6c1e30c2bcd6e74 [^] |
2019-02-15 11:05 | mtaal | Note Added: 0109857 | |
2019-02-15 11:05 | mtaal | Status | resolved => closed |
2019-06-12 23:04 | mtaal | Relationship added | related to 0041069 |
Copyright © 2000 - 2009 MantisBT Group |