Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0041069
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] StoreServermajoralways2019-06-11 10:512019-06-13 13:57
ReporterguillermogilView Statuspublic 
Assigned Tomtaal 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision1f97bb820e0b
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomigueldejuana
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0041069: SourceCode not updated after a deploy if the StoreServer is offline

DescriptionSourceCode not updated after a deploy if the StoreServer is offline
Steps To Reproduce- Login on WebPOS
- Logout
- Modify the source Code in central and store
- Compile Central and Store
- Stop central Server
- Login on WebPOS

Proposed SolutionDo not allow to do anything if the sourcecode is outdated
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to design defect 0040096 closedmigueldejuana Source verson check is not done for store server, add it to the central server login 
causes defect 0041323 closedmtaal Store server source version check not comparable with central server version check 

-  Notes
(0112764)
hgbot (developer)
2019-06-13 09:39

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 1f97bb820e0b47793b660db9a757b7b724dddedb
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Jun 13 09:38:49 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1f97bb820e0b47793b660db9a757b7b724dddedb [^]

Fixes issue 41069: SourceCode not updated after a deploy if the StoreServer is offline
Send the source version in a separate property when store server is offline. On the client
use the property to compare against the sourceversion without updating the sourceversion
in the client.

---
M src/org/openbravo/mobile/core/process/JSONProcessSimple.java
M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java
M web/org.openbravo.mobile.core/source/data/ob-datasource.js
---
(0112765)
mtaal (manager)
2019-06-13 09:45
edited on: 2019-06-14 10:27

To test:
- install multi-server
- run the browser on central url using ss also
- check that the sourceversion is set in the client
execute this in the client side chrome console:
OB.UTIL.localStorage.getItem('SourceVersion_' + OB.MobileApp.model.get('appName'))

- change the source version in the client manually through the console
In the client side console do:
OB.UTIL.localStorage.setItem('SourceVersion_' + OB.MobileApp.model.get('appName'), 'ABC')

- refresh: notice that a popup occurs and that the source version gets reset back (as cs is still there)

- stop the central server and stop the store server
- make a change in a javascript file on the store server
e.g. add this line:
if (true) {
console.log('test');
}
in the ob-requestrouter.js file.
Note: on an aws server this must be done in the webapps directory of tomcat (or otherwise a rebuild is needed)

- start the store server
- do any action in the client, the system will go offline

- when logging in (or earlier) the system will show a 'source changed popup'

- this popup will occur again when logging in

- restart cs, wait for the ss to go online

- login into webpos, see that the change source popup occurs once

- after logging in it should be fine

- now undo the change in javascript on the store server

- restart the store server

- login/do actions on webpos, should work

- stop central server

- do actions: store server goes offline

- check that in webpos you can do normal offline actions

- start cs again

- check that ss goes online

(0112769)
migueldejuana (developer)
2019-06-13 13:57

Reviewed

- Issue History
Date Modified Username Field Change
2019-06-11 10:51 guillermogil New Issue
2019-06-11 10:51 guillermogil Assigned To => StoreServer
2019-06-11 10:51 guillermogil Triggers an Emergency Pack => No
2019-06-12 15:57 mtaal Assigned To StoreServer => mtaal
2019-06-12 23:04 mtaal Relationship added related to 0040096
2019-06-13 09:39 hgbot Checkin
2019-06-13 09:39 hgbot Note Added: 0112764
2019-06-13 09:39 hgbot Status new => resolved
2019-06-13 09:39 hgbot Resolution open => fixed
2019-06-13 09:39 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1f97bb820e0b47793b660db9a757b7b724dddedb [^]
2019-06-13 09:45 mtaal Note Added: 0112765
2019-06-13 13:57 migueldejuana Review Assigned To => migueldejuana
2019-06-13 13:57 migueldejuana Note Added: 0112769
2019-06-13 13:57 migueldejuana Status resolved => closed
2019-06-14 10:24 mtaal Note Edited: 0112765 View Revisions
2019-06-14 10:27 mtaal Note Edited: 0112765 View Revisions
2019-07-09 15:57 mtaal Relationship added causes 0041323


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker