Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040096Retail ModulesStoreServerpublic2019-01-31 22:312019-02-15 11:05
Reportermtaal 
Assigned Tomigueldejuana 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040096: Source verson check is not done for store server, add it to the central server login
DescriptionThe source version check [1] with the if statement is never executed for a webapp loaded from central but talking to the store server. This in itself is fine as the code maybe loaded from central while the login happens on the store server.

In case of running webpos in multi-server always check the source version against the central server if available.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/web/org.openbravo.mobile.core/source/model/ob-terminal-model.js#l2189 [^]
Steps To ReproduceUse multi-server
Load the web app from central, see that sourceversion check is never done at login
Proposed SolutionAdd the source version check here [1]
To enable it let the ContextInformation request/service also return the sourceversion.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/web/org.openbravo.mobile.core/source/utils/ob-utilities.js#l1285 [^]
Additional Information
TagsNo tags attached.
Relationships
related to defect 0037159 closed marvintm new js file is not sent to terminal when login is done. Refresh browser is required 
related to defect 0041069 closed mtaal SourceCode not updated after a deploy if the StoreServer is offline 
Attached Filesdiff sourceversion_but.diff (4,186) 2019-02-14 17:49
https://issues.openbravo.com/file_download.php?file_id=12661&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-01-31 22:31mtaalNew Issue
2019-01-31 22:31mtaalAssigned To => migueldejuana
2019-01-31 22:31mtaalOBNetwork customer => No
2019-01-31 22:31mtaalTriggers an Emergency Pack => No
2019-01-31 22:32mtaalRelationship addedrelated to 0037159
2019-02-05 08:54guillermogilOBNetwork customerNo => Gold
2019-02-05 08:54guillermogilResolution time => 1550703600
2019-02-05 09:01guillermogilSummarySource verson check is not done for store serer, add it to the central server login => Source verson check is not done for store server, add it to the central server login
2019-02-14 17:49mtaalFile Added: sourceversion_but.diff
2019-02-14 17:49mtaalReview Assigned To => mtaal
2019-02-15 07:56hgbotCheckin
2019-02-15 07:56hgbotNote Added: 0109849
2019-02-15 07:56hgbotStatusnew => resolved
2019-02-15 07:56hgbotResolutionopen => fixed
2019-02-15 07:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0fd177011896adb9db4117dbe6c1e30c2bcd6e74 [^]
2019-02-15 11:05mtaalNote Added: 0109857
2019-02-15 11:05mtaalStatusresolved => closed
2019-06-12 23:04mtaalRelationship addedrelated to 0041069

Notes
(0109849)
hgbot   
2019-02-15 07:56   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 0fd177011896adb9db4117dbe6c1e30c2bcd6e74
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Feb 15 07:56:00 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0fd177011896adb9db4117dbe6c1e30c2bcd6e74 [^]

Fixed issue 0040096: Source verson check is not done for store server, add it to the central server login

- Do not use Store Server sourceVersion to know if code changed or not
- Evaluate sourceVersion always, not only for single server

---
M src/org/openbravo/mobile/core/login/MobileCoreLoginHandler.java
M src/org/openbravo/mobile/core/process/JSONProcessSimple.java
M web/org.openbravo.mobile.core/source/data/ob-datasource.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0109857)
mtaal   
2019-02-15 11:05   
reviewed and tested