Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0039879
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2019-01-08 10:122019-03-12 14:38
ReportergorkaionView Statuspublic 
Assigned Torqueralta 
PriorityurgentResolutionfixedFixed in VersionRR19Q2
StatusclosedFix in branchFixed in SCM revisionf885b855aa31
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0039879: ExternalOrderLoader should search entities based on POS Terminal Org instead of user readable orgs

DescriptionCurrently when searching an entity the DataResolver is filtering by the readable orgs of the context. If the default role of the user has access to different stores it is also considering entities of other stores.

The DataResolver should filter by the natural tree of the POS Terminal organization. So only entities accessible by the POS Terminal are considered by the DataResolver.
Steps To ReproduceConfigure different organizations, and create terminals for each of them.
Create the Promotion with the same Name to different stores.
Execute ExternalOrderLoader requests to both terminals using the promotion and a role that has access to both stores.
An error is thrown as all the promotions with the same name are found.
Proposed SolutionDefaultDataResolver should filter by the natural tree of the POS Terminal organization instead of the readable orgs.
TagsNo tags attached.
Attached Filesdiff file icon issue39879.diff [^] (1,612 bytes) 2019-01-08 10:46 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0039774 closedmarvintm Retail Modules ExternalOrderLoader should establish the context according to the POS Terminal specified in the request 
related to defect 0039813 closedranjith_qualiantech_com Retail Modules ExternalOrderLoader DefaultDataResolver does not filter by client id 
blocks design defect 0040591 closedalostale Openbravo ERP deprecate OBDal getReadableClientsInClause and getReadableOrganizationsInClause 

-  Notes
(0108931)
hgbot (developer)
2019-01-14 00:12

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f885b855aa31343faf02e4eb95d120fcfc8bfb17
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Sat Jan 12 07:39:48 2019 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f885b855aa31343faf02e4eb95d120fcfc8bfb17 [^]

Fixed issue 39879: ExternalOrderLoader should search entities based on POS
Terminal Org instead of user readable orgs

- Filtered by the natural tree of the POS Terminal organization instead of the
readable orgs.

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0110347)
hgbot (developer)
2019-03-11 12:57

 Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: 1a57e74935c7fa77c32fe097578871ee2904645c
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Wed Mar 06 10:33:57 2019 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/1a57e74935c7fa77c32fe097578871ee2904645c [^]

Related to issue 39879: added sampledata for testing purposes

---
M referencedata/sampledata/The_White_Valley_Group/M_OFFER.xml
M referencedata/sampledata/The_White_Valley_Group/M_OFFER_PRODUCT.xml
---
(0110348)
hgbot (developer)
2019-03-11 12:58

 Repository: tools/automation/pi-mobile
Changeset: 496caf5d92a07f66017e98650a0adf236a84f0dd
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Wed Mar 06 11:18:12 2019 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/496caf5d92a07f66017e98650a0adf236a84f0dd [^]

Related to issue 39879: added automated test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I39879_VerifyDiscountsWithSameNameAndDiffOrgs.java
---
(0110384)
hgbot (developer)
2019-03-12 14:38

 Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: f2842a683492b86e89a5a697d6b097902ee418d3
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Mon Mar 11 11:57:31 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/f2842a683492b86e89a5a697d6b097902ee418d3 [^]

Related to issue 39879: fixed sampledata

---
M referencedata/sampledata/The_White_Valley_Group/M_OFFER.xml
M referencedata/sampledata/The_White_Valley_Group/M_OFFER_PRODUCT.xml
---

- Issue History
Date Modified Username Field Change
2019-01-08 10:12 gorkaion New Issue
2019-01-08 10:12 gorkaion Assigned To => Retail
2019-01-08 10:12 gorkaion Resolution time => 1548716400
2019-01-08 10:12 gorkaion Triggers an Emergency Pack => No
2019-01-08 10:12 gorkaion Issue generated from 0039774
2019-01-08 10:12 gorkaion Relationship added related to 0039774
2019-01-08 10:23 rafaroda Issue Monitored: rafaroda
2019-01-08 10:38 gorkaion File Added: issue39879.diff
2019-01-08 10:45 gorkaion File Deleted: issue39879.diff
2019-01-08 10:45 gorkaion File Added: issue39879.diff
2019-01-08 10:46 gorkaion File Deleted: issue39879.diff
2019-01-08 10:46 gorkaion File Added: issue39879.diff
2019-01-09 04:41 rqueralta Assigned To Retail => rqueralta
2019-01-09 04:42 rqueralta Status new => scheduled
2019-01-09 09:46 rafaroda Relationship added related to 0039813
2019-01-14 00:12 hgbot Checkin
2019-01-14 00:12 hgbot Note Added: 0108931
2019-01-14 00:12 hgbot Status scheduled => resolved
2019-01-14 00:12 hgbot Resolution open => fixed
2019-01-14 00:12 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f885b855aa31343faf02e4eb95d120fcfc8bfb17 [^]
2019-01-17 18:25 marvintm Review Assigned To => marvintm
2019-01-17 18:25 marvintm Status resolved => closed
2019-01-17 18:25 marvintm Fixed in Version => RR19Q2
2019-03-11 12:57 hgbot Checkin
2019-03-11 12:57 hgbot Note Added: 0110347
2019-03-11 12:58 hgbot Checkin
2019-03-11 12:58 hgbot Note Added: 0110348
2019-03-12 14:38 hgbot Checkin
2019-03-12 14:38 hgbot Note Added: 0110384
2019-04-11 09:43 alostale Relationship added blocks 0040591

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker