Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0039813

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2018-12-17 11:05

2018-12-18 19:11

Reporter

gorkaion

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

urgent

Resolution

fixed

Fixed in Version

RR19Q1

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

marvintm

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0039813: ExternalOrderLoader DefaultDataResolver does not filter by client id

Description

On an environment with several clients. If you have the same search key for a product in different clients defined in * org. The DefaultDataResolver is not filtering by client id so it is not possible to determine the product id to use when using the search key.

Steps To Reproduce

On an environment with F&B and Whitevalley Group clients.

Configure in both clients a product with the same search key and stored in the * organization.

Try to load an order using ExternalOrderLoader where the product is set using the SearchKey. "No product could be found for...." error is returned. The real error is that 2 products are found and it is not possible to determine the correct product.

Try to load the same order but using the product id, check that in this case it works as expected.

Proposed Solution

Add the client to the query of the DefaultDataResolver:

String qryStr = "select id from " + entityName + " where " + property + "=:value"
+ " and organization.id " + OBDal.getInstance().getReadableOrganizationsInClause();
+ " and client.id " + OBDal.getInstance().getReadableClientsInClause();

Tags

No tags attached.

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0039774		closed	marvintm	ExternalOrderLoader should establish the context according to the POS Terminal specified in the request
related to	defect	0039879		closed	rqueralta	ExternalOrderLoader should search entities based on POS Terminal Org instead of user readable orgs

Notes
(0108662) hgbot (developer) 2018-12-18 10:18	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 565522f65fefaed3b1aeec40351baa2e19092408 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Tue Dec 18 14:48:24 2018 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/565522f65fefaed3b1aeec40351baa2e19092408 [^] Fixed issue 39813 : Added client Validation to ExternalOrderLoader DefaultDataResolver query --- M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java ---

Issue History
Date Modified	Username	Field	Change
2018-12-17 11:05	gorkaion	New Issue
2018-12-17 11:05	gorkaion	Assigned To	=> Retail
2018-12-17 11:05	gorkaion	Resolution time	=> 1546815600
2018-12-17 11:05	gorkaion	Triggers an Emergency Pack	=> No
2018-12-17 11:10	rafaroda	Issue Monitored: rafaroda
2018-12-17 11:11	rafaroda	Relationship added	related to 0039774
2018-12-17 17:08	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2018-12-18 08:06	ranjith_qualiantech_com	Status	new => scheduled
2018-12-18 10:18	hgbot	Checkin
2018-12-18 10:18	hgbot	Note Added: 0108662
2018-12-18 10:18	hgbot	Status	scheduled => resolved
2018-12-18 10:18	hgbot	Resolution	open => fixed
2018-12-18 10:18	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/565522f65fefaed3b1aeec40351baa2e19092408 [^]
2018-12-18 19:11	marvintm	Review Assigned To	=> marvintm
2018-12-18 19:11	marvintm	Status	resolved => closed
2018-12-18 19:11	marvintm	Fixed in Version	=> RR19Q1
2019-01-09 09:46	rafaroda	Relationship added	related to 0039879

Copyright © 2000 - 2009 MantisBT Group