Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039879Retail ModulesWeb POSpublic2019-01-08 10:122019-03-12 14:38
Reportergorkaion 
Assigned Torqueralta 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039879: ExternalOrderLoader should search entities based on POS Terminal Org instead of user readable orgs
DescriptionCurrently when searching an entity the DataResolver is filtering by the readable orgs of the context. If the default role of the user has access to different stores it is also considering entities of other stores.

The DataResolver should filter by the natural tree of the POS Terminal organization. So only entities accessible by the POS Terminal are considered by the DataResolver.
Steps To ReproduceConfigure different organizations, and create terminals for each of them.
Create the Promotion with the same Name to different stores.
Execute ExternalOrderLoader requests to both terminals using the promotion and a role that has access to both stores.
An error is thrown as all the promotions with the same name are found.
Proposed SolutionDefaultDataResolver should filter by the natural tree of the POS Terminal organization instead of the readable orgs.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0039774 closed marvintm Retail Modules ExternalOrderLoader should establish the context according to the POS Terminal specified in the request 
related to defect 0039813 closed ranjith_qualiantech_com Retail Modules ExternalOrderLoader DefaultDataResolver does not filter by client id 
blocks design defect 0040591 closed alostale Openbravo ERP deprecate OBDal getReadableClientsInClause and getReadableOrganizationsInClause 
Attached Filesdiff issue39879.diff (1,612) 2019-01-08 10:46
https://issues.openbravo.com/file_download.php?file_id=12490&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-01-08 10:12gorkaionNew Issue
2019-01-08 10:12gorkaionAssigned To => Retail
2019-01-08 10:12gorkaionResolution time => 1548716400
2019-01-08 10:12gorkaionTriggers an Emergency Pack => No
2019-01-08 10:12gorkaionIssue generated from0039774
2019-01-08 10:12gorkaionRelationship addedrelated to 0039774
2019-01-08 10:23rafarodaIssue Monitored: rafaroda
2019-01-08 10:38gorkaionFile Added: issue39879.diff
2019-01-08 10:45gorkaionFile Deleted: issue39879.diff
2019-01-08 10:45gorkaionFile Added: issue39879.diff
2019-01-08 10:46gorkaionFile Deleted: issue39879.diff
2019-01-08 10:46gorkaionFile Added: issue39879.diff
2019-01-09 04:41rqueraltaAssigned ToRetail => rqueralta
2019-01-09 04:42rqueraltaStatusnew => scheduled
2019-01-09 09:46rafarodaRelationship addedrelated to 0039813
2019-01-14 00:12hgbotCheckin
2019-01-14 00:12hgbotNote Added: 0108931
2019-01-14 00:12hgbotStatusscheduled => resolved
2019-01-14 00:12hgbotResolutionopen => fixed
2019-01-14 00:12hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f885b855aa31343faf02e4eb95d120fcfc8bfb17 [^]
2019-01-17 18:25marvintmReview Assigned To => marvintm
2019-01-17 18:25marvintmStatusresolved => closed
2019-01-17 18:25marvintmFixed in Version => RR19Q2
2019-03-11 12:57hgbotCheckin
2019-03-11 12:57hgbotNote Added: 0110347
2019-03-11 12:58hgbotCheckin
2019-03-11 12:58hgbotNote Added: 0110348
2019-03-12 14:38hgbotCheckin
2019-03-12 14:38hgbotNote Added: 0110384
2019-04-11 09:43alostaleRelationship addedblocks 0040591

Notes
(0108931)
hgbot   
2019-01-14 00:12   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f885b855aa31343faf02e4eb95d120fcfc8bfb17
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Sat Jan 12 07:39:48 2019 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f885b855aa31343faf02e4eb95d120fcfc8bfb17 [^]

Fixed issue 39879: ExternalOrderLoader should search entities based on POS
Terminal Org instead of user readable orgs

- Filtered by the natural tree of the POS Terminal organization instead of the
readable orgs.

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0110347)
hgbot   
2019-03-11 12:57   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: 1a57e74935c7fa77c32fe097578871ee2904645c
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Wed Mar 06 10:33:57 2019 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/1a57e74935c7fa77c32fe097578871ee2904645c [^]

Related to issue 39879: added sampledata for testing purposes

---
M referencedata/sampledata/The_White_Valley_Group/M_OFFER.xml
M referencedata/sampledata/The_White_Valley_Group/M_OFFER_PRODUCT.xml
---
(0110348)
hgbot   
2019-03-11 12:58   
Repository: tools/automation/pi-mobile
Changeset: 496caf5d92a07f66017e98650a0adf236a84f0dd
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Wed Mar 06 11:18:12 2019 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/496caf5d92a07f66017e98650a0adf236a84f0dd [^]

Related to issue 39879: added automated test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I39879_VerifyDiscountsWithSameNameAndDiffOrgs.java
---
(0110384)
hgbot   
2019-03-12 14:38   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: f2842a683492b86e89a5a697d6b097902ee418d3
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Mon Mar 11 11:57:31 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/f2842a683492b86e89a5a697d6b097902ee418d3 [^]

Related to issue 39879: fixed sampledata

---
M referencedata/sampledata/The_White_Valley_Group/M_OFFER.xml
M referencedata/sampledata/The_White_Valley_Group/M_OFFER_PRODUCT.xml
---