0039027: Terminal with empty cache receives an error retrieving current cashup when it have all payment methods inactive

Description

Login cannot be done in a terminal which match with the following conditions

a) Empty cache
b) Valid cashup (not processed)
c) Terminal should have several INACTIVE payment types (defined in POS terminal window)
c) Valid cashup should have a payment method cashup created for each inactive payment type

Under these circumstances, a null pointer exception is raised by org.openbravo.retail.posterminal.master.Cashup
Method: GetPayments

Below query results is null

      OBCriteria<OBPOSAppPayment> paymentAppMethodCriteria = OBDal.getInstance().createCriteria(
          OBPOSAppPayment.class);
      paymentAppMethodCriteria.add(Restrictions.eq(OBPOSAppPayment.PROPERTY_ID,
          paymentMethodJSON.get("paymentType")));
      OBPOSAppPayment paymentAppMethod = (OBPOSAppPayment) paymentAppMethodCriteria.uniqueResult();

Later on code tries to pick the lineNo field of the object created above which is null. It results in a NullPointerException

paymentMethodJSON.put("lineNo", paymentAppMethod.getLine());

Steps To Reproduce

Generate above scenario
Login

Proposed Solution

When a payment method cashup is connected with an inactive payment type, then lineNo should be 1

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0039026

closed

ranjith_qualiantech_com

Terminal with empty cache receives an error retrieving current cashup when it have all payment methods inactive

Notes
(0106014) hgbot (developer) 2018-07-30 12:37	Repository: retail/backports/3.0RR18Q3/org.openbravo.retail.posterminal Changeset: dd3e4bca929f54a843bcbd212c8be9e3ba84c8b2 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Mon Jul 30 16:07:06 2018 +0530 URL: http://code.openbravo.com/retail/backports/3.0RR18Q3/org.openbravo.retail.posterminal/rev/dd3e4bca929f54a843bcbd212c8be9e3ba84c8b2 [^] Fixed issue 39027 : Validate Invalid Payment Method while retrieving Cashup * For generating Payment Method lineNo while retrieving cashup, if Payment Method is not available then it should be replaced with one --- M src/org/openbravo/retail/posterminal/master/Cashup.java ---

Issue History
Date Modified	Username	Field	Change
2018-07-24 13:07	guilleaer	Type	defect => backport
2018-07-24 13:07	guilleaer	Target Version	=> RR18Q3.1
2018-07-26 09:05	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2018-07-30 12:37	hgbot	Checkin
2018-07-30 12:37	hgbot	Note Added: 0106014
2018-07-30 12:37	hgbot	Status	scheduled => resolved
2018-07-30 12:37	hgbot	Resolution	open => fixed
2018-07-30 12:37	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/retail/backports/3.0RR18Q3/org.openbravo.retail.posterminal/rev/dd3e4bca929f54a843bcbd212c8be9e3ba84c8b2 [^]
2018-08-01 08:48	marvintm	Target Version	RR18Q3.1 => RR18Q3
2018-08-01 08:49	marvintm	Review Assigned To	=> marvintm
2018-08-01 08:49	marvintm	Status	resolved => closed
2018-08-01 08:49	marvintm	Fixed in Version	=> RR18Q3