Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039027Retail ModulesWeb POSpublic2018-07-24 13:042018-08-01 08:49
Reporterguilleaer 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR18Q3Fixed in VersionRR18Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2017-04-05
Regression introduced in releaseRR17Q3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/741c14452bce [^]
Triggers an Emergency PackNo
Summary0039027: Terminal with empty cache receives an error retrieving current cashup when it have all payment methods inactive
DescriptionLogin cannot be done in a terminal which match with the following conditions

a) Empty cache
b) Valid cashup (not processed)
c) Terminal should have several INACTIVE payment types (defined in POS terminal window)
c) Valid cashup should have a payment method cashup created for each inactive payment type

Under these circumstances, a null pointer exception is raised by org.openbravo.retail.posterminal.master.Cashup
Method: GetPayments

Below query results is null

      OBCriteria<OBPOSAppPayment> paymentAppMethodCriteria = OBDal.getInstance().createCriteria(
          OBPOSAppPayment.class);
      paymentAppMethodCriteria.add(Restrictions.eq(OBPOSAppPayment.PROPERTY_ID,
          paymentMethodJSON.get("paymentType")));
      OBPOSAppPayment paymentAppMethod = (OBPOSAppPayment) paymentAppMethodCriteria.uniqueResult();

Later on code tries to pick the lineNo field of the object created above which is null. It results in a NullPointerException

paymentMethodJSON.put("lineNo", paymentAppMethod.getLine());
Steps To ReproduceGenerate above scenario
Login
Proposed SolutionWhen a payment method cashup is connected with an inactive payment type, then lineNo should be 1
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0039026 closed ranjith_qualiantech_com Terminal with empty cache receives an error retrieving current cashup when it have all payment methods inactive 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-07-24 13:07guilleaerTypedefect => backport
2018-07-24 13:07guilleaerTarget Version => RR18Q3.1
2018-07-26 09:05ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-07-30 12:37hgbotCheckin
2018-07-30 12:37hgbotNote Added: 0106014
2018-07-30 12:37hgbotStatusscheduled => resolved
2018-07-30 12:37hgbotResolutionopen => fixed
2018-07-30 12:37hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR18Q3/org.openbravo.retail.posterminal/rev/dd3e4bca929f54a843bcbd212c8be9e3ba84c8b2 [^]
2018-08-01 08:48marvintmTarget VersionRR18Q3.1 => RR18Q3
2018-08-01 08:49marvintmReview Assigned To => marvintm
2018-08-01 08:49marvintmStatusresolved => closed
2018-08-01 08:49marvintmFixed in Version => RR18Q3

Notes
(0106014)
hgbot   
2018-07-30 12:37   
Repository: retail/backports/3.0RR18Q3/org.openbravo.retail.posterminal
Changeset: dd3e4bca929f54a843bcbd212c8be9e3ba84c8b2
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jul 30 16:07:06 2018 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR18Q3/org.openbravo.retail.posterminal/rev/dd3e4bca929f54a843bcbd212c8be9e3ba84c8b2 [^]

Fixed issue 39027 : Validate Invalid Payment Method while retrieving Cashup

* For generating Payment Method lineNo while retrieving cashup, if Payment Method is not available then it should be replaced with one

---
M src/org/openbravo/retail/posterminal/master/Cashup.java
---