Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0039026
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POScriticalhave not tried2018-07-24 13:042018-07-26 15:31
ReporterguilleaerView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in VersionRR18Q4
StatusclosedFix in branchFixed in SCM revision24f1e7cec00b
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression levelProduction - Confirmed Stable
Regression date2017-04-05
Regression introduced in releaseRR17Q3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/741c14452bce [^]
Triggers an Emergency PackNo
Summary

0039026: Terminal with empty cache receives an error retrieving current cashup when it have all payment methods inactive

DescriptionLogin cannot be done in a terminal which match with the following conditions

a) Empty cache
b) Valid cashup (not processed)
c) Terminal should have several INACTIVE payment types (defined in POS terminal window)
c) Valid cashup should have a payment method cashup created for each inactive payment type

Under these circumstances, a null pointer exception is raised by org.openbravo.retail.posterminal.master.Cashup
Method: GetPayments

Below query results is null

      OBCriteria<OBPOSAppPayment> paymentAppMethodCriteria = OBDal.getInstance().createCriteria(
          OBPOSAppPayment.class);
      paymentAppMethodCriteria.add(Restrictions.eq(OBPOSAppPayment.PROPERTY_ID,
          paymentMethodJSON.get("paymentType")));
      OBPOSAppPayment paymentAppMethod = (OBPOSAppPayment) paymentAppMethodCriteria.uniqueResult();

Later on code tries to pick the lineNo field of the object created above which is null. It results in a NullPointerException

paymentMethodJSON.put("lineNo", paymentAppMethod.getLine());



3146207 [http-bio-8098-exec-62] ERROR org.openbravo.retail.posterminal.master.Cashup - Error during exec
java.lang.NullPointerException
  at org.openbravo.retail.posterminal.master.Cashup.getPayments(Cashup.java:161)
Steps To ReproduceGenerate above scenario
Login
Proposed SolutionWhen a payment method cashup is connected with an inactive payment type, then lineNo should be 1
TagsNo tags attached.
Attached Filesdiff file icon diffIssue39026_Sharaf.diff [^] (3,469 bytes) 2018-07-24 13:05 [Show Content]
? file icon usefulQueriesToReproduce.sql [^] (2,376 bytes) 2018-07-24 13:17

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 0039027RR18Q3 closedranjith_qualiantech_com Terminal with empty cache receives an error retrieving current cashup when it have all payment methods inactive 
depends on backport 0039028RR18Q2.2 closedranjith_qualiantech_com Terminal with empty cache receives an error retrieving current cashup when it have all payment methods inactive 

-  Notes
(0105913)
guilleaer (manager)
2018-07-24 13:06

Patch applies to Sharaf environment. Should be adapted for PI and backports
(0105958)
hgbot (developer)
2018-07-26 12:13

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 24f1e7cec00bf9acd44c4fd29258a47b917826d4
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Jul 26 15:43:32 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/24f1e7cec00bf9acd44c4fd29258a47b917826d4 [^]

Fixed issue 39026 : Validate Invalid Payment Method while retrieving Cashup

* For generating Payment Method lineNo while retrieving cashup, if Payment Method is not available then it should be replaced with one

---
M src/org/openbravo/retail/posterminal/master/Cashup.java
---

- Issue History
Date Modified Username Field Change
2018-07-24 13:04 guilleaer New Issue
2018-07-24 13:04 guilleaer Assigned To => Retail
2018-07-24 13:04 guilleaer Regression level => Production - Confirmed Stable
2018-07-24 13:04 guilleaer Regression date => 2017-04-05
2018-07-24 13:04 guilleaer Regression introduced in release => RR17Q3
2018-07-24 13:04 guilleaer Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/741c14452bce [^]
2018-07-24 13:04 guilleaer Triggers an Emergency Pack => No
2018-07-24 13:05 guilleaer File Added: diffIssue39026_Sharaf.diff
2018-07-24 13:06 guilleaer Note Added: 0105913
2018-07-24 13:07 guilleaer Status new => scheduled
2018-07-24 13:17 guilleaer File Added: usefulQueriesToReproduce.sql
2018-07-24 13:17 guilleaer Description Updated View Revisions
2018-07-24 13:25 egoitz Resolution time => 1533074400
2018-07-26 08:05 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2018-07-26 12:13 hgbot Checkin
2018-07-26 12:13 hgbot Note Added: 0105958
2018-07-26 12:13 hgbot Status scheduled => resolved
2018-07-26 12:13 hgbot Resolution open => fixed
2018-07-26 12:13 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/24f1e7cec00bf9acd44c4fd29258a47b917826d4 [^]
2018-07-26 15:31 marvintm Review Assigned To => marvintm
2018-07-26 15:31 marvintm Status resolved => closed
2018-07-26 15:31 marvintm Fixed in Version => RR18Q4


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker