0039026: Terminal with empty cache receives an error retrieving current cashup when it have all payment methods inactive

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0039026

Retail Modules

Web POS

public

2018-07-24 13:04

2018-07-26 15:31

Reporter

guilleaer

Assigned To

ranjith_qualiantech_com

Priority

normal

Severity

critical

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR18Q4

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Production - Confirmed Stable

Regression date

2017-04-05

Regression introduced in release

RR17Q3

Regression introduced by commit

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/741c14452bce [^]

Triggers an Emergency Pack

Summary

0039026: Terminal with empty cache receives an error retrieving current cashup when it have all payment methods inactive

Description

Login cannot be done in a terminal which match with the following conditions

a) Empty cache
b) Valid cashup (not processed)
c) Terminal should have several INACTIVE payment types (defined in POS terminal window)
c) Valid cashup should have a payment method cashup created for each inactive payment type

Under these circumstances, a null pointer exception is raised by org.openbravo.retail.posterminal.master.Cashup
Method: GetPayments

Below query results is null

      OBCriteria<OBPOSAppPayment> paymentAppMethodCriteria = OBDal.getInstance().createCriteria(
          OBPOSAppPayment.class);
      paymentAppMethodCriteria.add(Restrictions.eq(OBPOSAppPayment.PROPERTY_ID,
          paymentMethodJSON.get("paymentType")));
      OBPOSAppPayment paymentAppMethod = (OBPOSAppPayment) paymentAppMethodCriteria.uniqueResult();

Later on code tries to pick the lineNo field of the object created above which is null. It results in a NullPointerException

paymentMethodJSON.put("lineNo", paymentAppMethod.getLine());

3146207 [http-bio-8098-exec-62] ERROR org.openbravo.retail.posterminal.master.Cashup - Error during exec
java.lang.NullPointerException
  at org.openbravo.retail.posterminal.master.Cashup.getPayments(Cashup.java:161)

Steps To Reproduce

Generate above scenario
Login

Proposed Solution

When a payment method cashup is connected with an inactive payment type, then lineNo should be 1

Additional Information

Tags

No tags attached.

Relationships

depends on	backport	0039027	RR18Q3	closed	ranjith_qualiantech_com	Terminal with empty cache receives an error retrieving current cashup when it have all payment methods inactive
depends on	backport	0039028	RR18Q2.2	closed	ranjith_qualiantech_com	Terminal with empty cache receives an error retrieving current cashup when it have all payment methods inactive