Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0038621
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2018-05-24 17:442018-06-06 13:43
ReportermigueldejuanaView Statuspublic 
Assigned Tomigueldejuana 
PrioritynormalResolutionfixedFixed in VersionRR18Q3
StatusclosedFix in branchFixed in SCM revision46107eed74ff
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0038621: Avoid loosing orders if backend throws exception while inserting import entry

DescriptionWhen an order is send to backend, it is removed from local database when we get the success response. It is remove because the import entry is created and no need to have the message in local database.

There is one case thaht is not covered. When synchornizating the message, in the process of inserting the import entry we could throw an exception(i.e.: The backend timeout finish before client timeout. Wring development). This exception is send as success with status -1. Wrongly, we are considering it as a success and we remove the message loosing the order.
Steps To Reproduce- Add an exception in the process of saving the Import Entry. In WebServiceAuthenticatedServlet for example.
- Create an order and process it
- ERROR! The Exception will be thrown, the import entry is not created and the message is removed from local database.
Proposed SolutionIn the success callback, if the status is -1, do not remove the message and call error callback.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0038626RR18Q2.1 closedmigueldejuana Avoid loosing orders if backend throws exception while inserting import entry 
depends on backport 0038627 closedmigueldejuana Avoid loosing orders if backend throws exception while inserting import entry 

-  Notes
(0104732)
hgbot (developer)
2018-05-28 08:22

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 126c7b2910b1493f49a6ebfe545d0fda618e811e
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri May 25 10:07:56 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/126c7b2910b1493f49a6ebfe545d0fda618e811e [^]

Fixed issue 0038621: Avoid loosing orders if backend throws exception while inserting import entry

- Handle response with status -1 and follow the error flow to do not remove the message which couldn't be saved

---
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
---
(0104733)
hgbot (developer)
2018-05-28 08:23

 Repository: retail/backports/3.0RR18Q1.4/org.openbravo.mobile.core
Changeset: 4afd30b27187169188357f2db94debe4f0e736fe
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri May 25 10:07:56 2018 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR18Q1.4/org.openbravo.mobile.core/rev/4afd30b27187169188357f2db94debe4f0e736fe [^]

Fixed issue 0038621: Avoid loosing orders if backend throws exception while inserting import entry

- Handle response with status -1 and follow the error flow to do not remove the message which couldn't be saved

---
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
---
(0104734)
hgbot (developer)
2018-05-28 08:24

 Repository: retail/backports/3.0RR18Q2.1/org.openbravo.mobile.core
Changeset: 46107eed74ff1fe645269105ce82650fa1dddee2
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri May 25 10:07:56 2018 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR18Q2.1/org.openbravo.mobile.core/rev/46107eed74ff1fe645269105ce82650fa1dddee2 [^]

Fixed issue 0038621: Avoid loosing orders if backend throws exception while inserting import entry

- Handle response with status -1 and follow the error flow to do not remove the message which couldn't be saved

---
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
---

- Issue History
Date Modified Username Field Change
2018-05-24 17:44 migueldejuana New Issue
2018-05-24 17:44 migueldejuana Assigned To => migueldejuana
2018-05-24 17:44 migueldejuana Triggers an Emergency Pack => No
2018-05-25 10:12 migueldejuana Status new => scheduled
2018-05-28 08:22 hgbot Checkin
2018-05-28 08:22 hgbot Note Added: 0104732
2018-05-28 08:22 hgbot Status scheduled => resolved
2018-05-28 08:22 hgbot Resolution open => fixed
2018-05-28 08:22 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/126c7b2910b1493f49a6ebfe545d0fda618e811e [^]
2018-05-28 08:23 hgbot Checkin
2018-05-28 08:23 hgbot Note Added: 0104733
2018-05-28 08:23 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/126c7b2910b1493f49a6ebfe545d0fda618e811e [^] => http://code.openbravo.com/retail/backports/3.0RR18Q1.4/org.openbravo.mobile.core/rev/4afd30b27187169188357f2db94debe4f0e736fe [^]
2018-05-28 08:24 hgbot Checkin
2018-05-28 08:24 hgbot Note Added: 0104734
2018-05-28 08:24 hgbot Fixed in SCM revision http://code.openbravo.com/retail/backports/3.0RR18Q1.4/org.openbravo.mobile.core/rev/4afd30b27187169188357f2db94debe4f0e736fe [^] => http://code.openbravo.com/retail/backports/3.0RR18Q2.1/org.openbravo.mobile.core/rev/46107eed74ff1fe645269105ce82650fa1dddee2 [^]
2018-06-06 13:43 marvintm Review Assigned To => marvintm
2018-06-06 13:43 marvintm Status resolved => closed
2018-06-06 13:43 marvintm Fixed in Version => RR18Q3

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker