Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038621Retail ModulesWeb POSpublic2018-05-24 17:442018-06-06 13:43
Reportermigueldejuana 
Assigned Tomigueldejuana 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038621: Avoid loosing orders if backend throws exception while inserting import entry
DescriptionWhen an order is send to backend, it is removed from local database when we get the success response. It is remove because the import entry is created and no need to have the message in local database.

There is one case thaht is not covered. When synchornizating the message, in the process of inserting the import entry we could throw an exception(i.e.: The backend timeout finish before client timeout. Wring development). This exception is send as success with status -1. Wrongly, we are considering it as a success and we remove the message loosing the order.
Steps To Reproduce- Add an exception in the process of saving the Import Entry. In WebServiceAuthenticatedServlet for example.
- Create an order and process it
- ERROR! The Exception will be thrown, the import entry is not created and the message is removed from local database.
Proposed SolutionIn the success callback, if the status is -1, do not remove the message and call error callback.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0038626RR18Q2.1 closed migueldejuana Avoid loosing orders if backend throws exception while inserting import entry 
depends on backport 0038627 closed migueldejuana Avoid loosing orders if backend throws exception while inserting import entry 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-05-24 17:44migueldejuanaNew Issue
2018-05-24 17:44migueldejuanaAssigned To => migueldejuana
2018-05-24 17:44migueldejuanaTriggers an Emergency Pack => No
2018-05-25 10:12migueldejuanaStatusnew => scheduled
2018-05-28 08:22hgbotCheckin
2018-05-28 08:22hgbotNote Added: 0104732
2018-05-28 08:22hgbotStatusscheduled => resolved
2018-05-28 08:22hgbotResolutionopen => fixed
2018-05-28 08:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/126c7b2910b1493f49a6ebfe545d0fda618e811e [^]
2018-05-28 08:23hgbotCheckin
2018-05-28 08:23hgbotNote Added: 0104733
2018-05-28 08:23hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/126c7b2910b1493f49a6ebfe545d0fda618e811e [^] => http://code.openbravo.com/retail/backports/3.0RR18Q1.4/org.openbravo.mobile.core/rev/4afd30b27187169188357f2db94debe4f0e736fe [^]
2018-05-28 08:24hgbotCheckin
2018-05-28 08:24hgbotNote Added: 0104734
2018-05-28 08:24hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR18Q1.4/org.openbravo.mobile.core/rev/4afd30b27187169188357f2db94debe4f0e736fe [^] => http://code.openbravo.com/retail/backports/3.0RR18Q2.1/org.openbravo.mobile.core/rev/46107eed74ff1fe645269105ce82650fa1dddee2 [^]
2018-06-06 13:43marvintmReview Assigned To => marvintm
2018-06-06 13:43marvintmStatusresolved => closed
2018-06-06 13:43marvintmFixed in Version => RR18Q3

Notes
(0104732)
hgbot   
2018-05-28 08:22   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 126c7b2910b1493f49a6ebfe545d0fda618e811e
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri May 25 10:07:56 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/126c7b2910b1493f49a6ebfe545d0fda618e811e [^]

Fixed issue 0038621: Avoid loosing orders if backend throws exception while inserting import entry

- Handle response with status -1 and follow the error flow to do not remove the message which couldn't be saved

---
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
---
(0104733)
hgbot   
2018-05-28 08:23   
Repository: retail/backports/3.0RR18Q1.4/org.openbravo.mobile.core
Changeset: 4afd30b27187169188357f2db94debe4f0e736fe
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri May 25 10:07:56 2018 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR18Q1.4/org.openbravo.mobile.core/rev/4afd30b27187169188357f2db94debe4f0e736fe [^]

Fixed issue 0038621: Avoid loosing orders if backend throws exception while inserting import entry

- Handle response with status -1 and follow the error flow to do not remove the message which couldn't be saved

---
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
---
(0104734)
hgbot   
2018-05-28 08:24   
Repository: retail/backports/3.0RR18Q2.1/org.openbravo.mobile.core
Changeset: 46107eed74ff1fe645269105ce82650fa1dddee2
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri May 25 10:07:56 2018 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR18Q2.1/org.openbravo.mobile.core/rev/46107eed74ff1fe645269105ce82650fa1dddee2 [^]

Fixed issue 0038621: Avoid loosing orders if backend throws exception while inserting import entry

- Handle response with status -1 and follow the error flow to do not remove the message which couldn't be saved

---
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
---