Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0038319
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2018-04-10 19:452018-05-09 19:29
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version3.0PR18Q3
StatusclosedFix in branchFixed in SCM revisionad665ee3f59e
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0038319: Skip grid config related junit tests if any module shipping grid configuration is installed - part3

DescriptionSame case as already reported and partially fixed in issue 34769 and 35303.

The GCSequenceNumberTests junit test is the 3rd junit test in pi which test Grid Config for correct behavior.

It does that by creating some specific Grid Config on Tab Level entries and verifies the expected behavior.

However when that test-case is ran in a environment having some other grid config module installed for the same tab i.e. Business Partner that can lead to random behavior.

I.e. both rows same sequencenumbers (10) -> so order by essentially still random.

Noticed in CI tests mod-BUT related test as 'randomly failing'

Same fix as done in the other 2 issues -> auto-skip junit test if any non-core grid config entries are detected.
Steps To Reproducehttps://ci.openbravo.com/job/mod-simple/23260/testReport/junit/org.openbravo.test.views/GCSequenceNumberTests/differentTabSameSequenceNumber/ [^]

Note -> Test will not fails always but appears as random failure.
Proposed SolutionApply same change 'auto-skip' if any other grid-config entries are found.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0034769 closedalostale Skip grid config related junit tests if any module shipping grid configuration is installed. 
related to defect 0035303 closedshuehner Skip grid config related junit tests if any module shipping grid configuration is installed - part2 
related to defect 0039699 closedcaristu SortingFilteringGridConfiguration is failing when it should be skipped 

-  Notes
(0103787)
shuehner (administrator)
2018-04-10 19:50

 Expected behavior for review:
a.) run junit test in pristine pi -> the test should run unchanged (and not be skipped)
b.) install module shipping grid config: i.e.
https://code.openbravo.com/erp/pmods/org.openbravo.retail.highvolumesconfig [^]
Then run junit test again and it should automatically skip that 3 testcases.
(0103788)
hgbot (developer)
2018-04-10 19:52

 Repository: erp/devel/pi
Changeset: ad665ee3f59e99f525968dfa4dd8a4405c87eda9
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Apr 10 19:48:23 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ad665ee3f59e99f525968dfa4dd8a4405c87eda9 [^]

Fixed 38319. Auto-skip grid config junit test if other grid config present.

That test creates a specially crated grid config entry and verifies expected
behavior. That indirectly requires no other conflicting grid config present
for the same object (i.e. Business Partner tab). So auto-skip this testcase
if any non-core grid config is found similar to what the other 2 grid config
related tests already do.

---
M src-test/src/org/openbravo/test/views/GCSequenceNumberTests.java
---
(0103819)
hgbot (developer)
2018-04-11 16:07

 Repository: erp/devel/pi
Changeset: d28ede862e61e587bd4b5e9a7335111f0625a8e1
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Apr 11 16:07:07 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d28ede862e61e587bd4b5e9a7335111f0625a8e1 [^]

related to issue 38319: avoid duplication

---
M src-test/src/org/openbravo/test/views/GCSequenceNumberTests.java
M src-test/src/org/openbravo/test/views/SortingFilteringGridConfiguration.java
M src-test/src/org/openbravo/test/views/ViewGenerationWithDifferentConfigLevelTest.java
A src-test/src/org/openbravo/test/views/GridConfigurationTest.java
---
(0103820)
caristu (developer)
2018-04-11 16:08

 Code reviewed + tested OK.
(0104371)
hudsonbot (developer)
2018-05-09 19:29

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2be7d3efe606 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2018-04-10 19:45 shuehner New Issue
2018-04-10 19:45 shuehner Assigned To => platform
2018-04-10 19:45 shuehner Modules => Core
2018-04-10 19:45 shuehner Triggers an Emergency Pack => No
2018-04-10 19:45 shuehner Relationship added related to 0034769
2018-04-10 19:45 shuehner Relationship added related to 0035303
2018-04-10 19:50 shuehner Note Added: 0103787
2018-04-10 19:52 hgbot Checkin
2018-04-10 19:52 hgbot Note Added: 0103788
2018-04-10 19:52 hgbot Status new => resolved
2018-04-10 19:52 hgbot Resolution open => fixed
2018-04-10 19:52 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ad665ee3f59e99f525968dfa4dd8a4405c87eda9 [^]
2018-04-10 19:52 shuehner Review Assigned To => caristu
2018-04-10 19:52 shuehner Assigned To platform => shuehner
2018-04-11 16:07 hgbot Checkin
2018-04-11 16:07 hgbot Note Added: 0103819
2018-04-11 16:08 caristu Note Added: 0103820
2018-04-11 16:08 caristu Status resolved => closed
2018-04-11 16:08 caristu Fixed in Version => 3.0PR18Q3
2018-05-09 19:29 hudsonbot Checkin
2018-05-09 19:29 hudsonbot Note Added: 0104371
2018-11-27 10:46 caristu Relationship added related to 0039699

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker