Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0034769 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2016-12-19 11:50 | 2016-12-27 10:17 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR17Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | fdaa72200164 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | inigosanchez | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0034769: Skip grid config related junit tests if any module shipping grid configuration is installed. | |||||||
| Description | src-test of pi has several grid configuration related junit tests which indirectly assume no other grid configuration is applied. In some mod-* modules related ci tests there are modules installed shipping grid configuration which makes those core junit test fail (ca. 120 individual tests). It would be nice if the core junit test could be enhanced to 'skip' themselves if they defect any grid config (i.e. by doing db query or similar). | |||||||
| Steps To Reproduce | run junit tests in an environment with grid configuration installed example job: https://ci.openbravo.com/job/mod-simple/8092/#showFailuresLink [^] | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||||||||||||||||
|
||||||||||||||||||||||
 Relationships |
|
Notes |
|
|
(0092774) hgbot (developer) 2016-12-19 12:22 |
Repository: erp/devel/pi Changeset: fdaa722001641768b57c5a56c68a88c47f2f3957 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Mon Dec 19 12:19:33 2016 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/fdaa722001641768b57c5a56c68a88c47f2f3957 [^] fixed issue 34769: Skip grid config related tests if there are custom configs When a module ships custom grid configurations, it is possible they to interfer with expected values in test cases checking grid config behavior. Skip these tests in those cases. Note there are a couple of configurations shipped by core, they shouldn't be considered. --- M src-test/src/org/openbravo/test/views/ViewGenerationWithDifferentConfigLevelTest.java --- |
|
(0092800) hudsonbot (developer) 2016-12-19 23:17 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8c51303887c8 [^] Maturity status: Test |
|
(0093009) inigosanchez (developer) 2016-12-27 10:17 |
Code review and tested in pi@304cd8d235f9 With core grid config -> Tests are not skipped -> OK. Create a custom grid config -> Tests are skipped -> OK. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-12-19 11:50 | shuehner | New Issue | |
| 2016-12-19 11:50 | shuehner | Assigned To | => platform |
| 2016-12-19 11:50 | shuehner | Modules | => Core |
| 2016-12-19 11:50 | shuehner | Triggers an Emergency Pack | => No |
| 2016-12-19 12:09 | alostale | Relationship added | related to 0028478 |
| 2016-12-19 12:09 | alostale | Assigned To | platform => alostale |
| 2016-12-19 12:22 | hgbot | Checkin | |
| 2016-12-19 12:22 | hgbot | Note Added: 0092774 | |
| 2016-12-19 12:22 | hgbot | Status | new => resolved |
| 2016-12-19 12:22 | hgbot | Resolution | open => fixed |
| 2016-12-19 12:22 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/fdaa722001641768b57c5a56c68a88c47f2f3957 [^] |
| 2016-12-19 23:17 | hudsonbot | Checkin | |
| 2016-12-19 23:17 | hudsonbot | Note Added: 0092800 | |
| 2016-12-23 08:54 | alostale | Review Assigned To | => inigosanchez |
| 2016-12-27 10:17 | inigosanchez | Note Added: 0093009 | |
| 2016-12-27 10:17 | inigosanchez | Status | resolved => closed |
| 2016-12-27 10:17 | inigosanchez | Fixed in Version | => 3.0PR17Q1 |
| 2017-02-19 13:59 | shuehner | Relationship added | related to 0035303 |
| 2018-04-10 19:45 | shuehner | Relationship added | related to 0038319 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |