Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034769Openbravo ERPA. Platformpublic2016-12-19 11:502016-12-27 10:17
Reportershuehner 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Toinigosanchez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034769: Skip grid config related junit tests if any module shipping grid configuration is installed.
Descriptionsrc-test of pi has several grid configuration related junit tests which indirectly assume no other grid configuration is applied.

In some mod-* modules related ci tests there are modules installed shipping grid configuration which makes those core junit test fail (ca. 120 individual tests).

It would be nice if the core junit test could be enhanced to 'skip' themselves if they defect any grid config (i.e. by doing db query or similar).

Steps To Reproducerun junit tests in an environment with grid configuration installed
example job:
https://ci.openbravo.com/job/mod-simple/8092/#showFailuresLink [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0028478 closed NaroaIriarte view generation: unneeded queries to grid config tables 
related to defect 0035303 closed shuehner Skip grid config related junit tests if any module shipping grid configuration is installed - part2 
related to defect 0038319 closed shuehner Skip grid config related junit tests if any module shipping grid configuration is installed - part3 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-12-19 11:50shuehnerNew Issue
2016-12-19 11:50shuehnerAssigned To => platform
2016-12-19 11:50shuehnerModules => Core
2016-12-19 11:50shuehnerTriggers an Emergency Pack => No
2016-12-19 12:09alostaleRelationship addedrelated to 0028478
2016-12-19 12:09alostaleAssigned Toplatform => alostale
2016-12-19 12:22hgbotCheckin
2016-12-19 12:22hgbotNote Added: 0092774
2016-12-19 12:22hgbotStatusnew => resolved
2016-12-19 12:22hgbotResolutionopen => fixed
2016-12-19 12:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/fdaa722001641768b57c5a56c68a88c47f2f3957 [^]
2016-12-19 23:17hudsonbotCheckin
2016-12-19 23:17hudsonbotNote Added: 0092800
2016-12-23 08:54alostaleReview Assigned To => inigosanchez
2016-12-27 10:17inigosanchezNote Added: 0093009
2016-12-27 10:17inigosanchezStatusresolved => closed
2016-12-27 10:17inigosanchezFixed in Version => 3.0PR17Q1
2017-02-19 13:59shuehnerRelationship addedrelated to 0035303
2018-04-10 19:45shuehnerRelationship addedrelated to 0038319

Notes
(0092774)
hgbot   
2016-12-19 12:22   
Repository: erp/devel/pi
Changeset: fdaa722001641768b57c5a56c68a88c47f2f3957
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Dec 19 12:19:33 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/fdaa722001641768b57c5a56c68a88c47f2f3957 [^]

fixed issue 34769: Skip grid config related tests if there are custom configs

  When a module ships custom grid configurations, it is possible they to interfer
  with expected values in test cases checking grid config behavior.

  Skip these tests in those cases. Note there are a couple of configurations shipped
  by core, they shouldn't be considered.

---
M src-test/src/org/openbravo/test/views/ViewGenerationWithDifferentConfigLevelTest.java
---
(0092800)
hudsonbot   
2016-12-19 23:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8c51303887c8 [^]
Maturity status: Test
(0093009)
inigosanchez   
2016-12-27 10:17   
Code review and tested in pi@304cd8d235f9

With core grid config -> Tests are not skipped -> OK.
Create a custom grid config -> Tests are skipped -> OK.