Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038319Openbravo ERPA. Platformpublic2018-04-10 19:452018-05-09 19:29
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q3 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038319: Skip grid config related junit tests if any module shipping grid configuration is installed - part3
DescriptionSame case as already reported and partially fixed in issue 34769 and 35303.

The GCSequenceNumberTests junit test is the 3rd junit test in pi which test Grid Config for correct behavior.

It does that by creating some specific Grid Config on Tab Level entries and verifies the expected behavior.

However when that test-case is ran in a environment having some other grid config module installed for the same tab i.e. Business Partner that can lead to random behavior.

I.e. both rows same sequencenumbers (10) -> so order by essentially still random.

Noticed in CI tests mod-BUT related test as 'randomly failing'

Same fix as done in the other 2 issues -> auto-skip junit test if any non-core grid config entries are detected.
Steps To Reproducehttps://ci.openbravo.com/job/mod-simple/23260/testReport/junit/org.openbravo.test.views/GCSequenceNumberTests/differentTabSameSequenceNumber/ [^]

Note -> Test will not fails always but appears as random failure.
Proposed SolutionApply same change 'auto-skip' if any other grid-config entries are found.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0034769 closed alostale Skip grid config related junit tests if any module shipping grid configuration is installed. 
related to defect 0035303 closed shuehner Skip grid config related junit tests if any module shipping grid configuration is installed - part2 
related to defect 0039699 closed caristu SortingFilteringGridConfiguration is failing when it should be skipped 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-04-10 19:45shuehnerNew Issue
2018-04-10 19:45shuehnerAssigned To => platform
2018-04-10 19:45shuehnerModules => Core
2018-04-10 19:45shuehnerTriggers an Emergency Pack => No
2018-04-10 19:45shuehnerRelationship addedrelated to 0034769
2018-04-10 19:45shuehnerRelationship addedrelated to 0035303
2018-04-10 19:50shuehnerNote Added: 0103787
2018-04-10 19:52hgbotCheckin
2018-04-10 19:52hgbotNote Added: 0103788
2018-04-10 19:52hgbotStatusnew => resolved
2018-04-10 19:52hgbotResolutionopen => fixed
2018-04-10 19:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ad665ee3f59e99f525968dfa4dd8a4405c87eda9 [^]
2018-04-10 19:52shuehnerReview Assigned To => caristu
2018-04-10 19:52shuehnerAssigned Toplatform => shuehner
2018-04-11 16:07hgbotCheckin
2018-04-11 16:07hgbotNote Added: 0103819
2018-04-11 16:08caristuNote Added: 0103820
2018-04-11 16:08caristuStatusresolved => closed
2018-04-11 16:08caristuFixed in Version => 3.0PR18Q3
2018-05-09 19:29hudsonbotCheckin
2018-05-09 19:29hudsonbotNote Added: 0104371
2018-11-27 10:46caristuRelationship addedrelated to 0039699

Notes
(0103787)
shuehner   
2018-04-10 19:50   
Expected behavior for review:
a.) run junit test in pristine pi -> the test should run unchanged (and not be skipped)
b.) install module shipping grid config: i.e.
https://code.openbravo.com/erp/pmods/org.openbravo.retail.highvolumesconfig [^]
Then run junit test again and it should automatically skip that 3 testcases.
(0103788)
hgbot   
2018-04-10 19:52   
Repository: erp/devel/pi
Changeset: ad665ee3f59e99f525968dfa4dd8a4405c87eda9
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Apr 10 19:48:23 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ad665ee3f59e99f525968dfa4dd8a4405c87eda9 [^]

Fixed 38319. Auto-skip grid config junit test if other grid config present.

That test creates a specially crated grid config entry and verifies expected
behavior. That indirectly requires no other conflicting grid config present
for the same object (i.e. Business Partner tab). So auto-skip this testcase
if any non-core grid config is found similar to what the other 2 grid config
related tests already do.

---
M src-test/src/org/openbravo/test/views/GCSequenceNumberTests.java
---
(0103819)
hgbot   
2018-04-11 16:07   
Repository: erp/devel/pi
Changeset: d28ede862e61e587bd4b5e9a7335111f0625a8e1
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Apr 11 16:07:07 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d28ede862e61e587bd4b5e9a7335111f0625a8e1 [^]

related to issue 38319: avoid duplication

---
M src-test/src/org/openbravo/test/views/GCSequenceNumberTests.java
M src-test/src/org/openbravo/test/views/SortingFilteringGridConfiguration.java
M src-test/src/org/openbravo/test/views/ViewGenerationWithDifferentConfigLevelTest.java
A src-test/src/org/openbravo/test/views/GridConfigurationTest.java
---
(0103820)
caristu   
2018-04-11 16:08   
Code reviewed + tested OK.
(0104371)
hudsonbot   
2018-05-09 19:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2be7d3efe606 [^]
Maturity status: Test