Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0037832
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSmajoralways2018-02-05 12:042018-04-18 11:14
ReportermarvintmView Statuspublic 
Assigned ToRetail 
PriorityurgentResolutionfixedFixed in VersionRR18Q1.2
StatusclosedFix in branchFixed in SCM revision7915eaa1481b
ProjectionnoneETAnoneTarget VersionRR18Q1.2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression levelProduction - QA Approved
Regression date2017-11-22
Regression introduced in releaseRR18Q1
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a2186d120ffa [^]
Triggers an Emergency PackNo
Summary

0037832: Concurrency check in the OrderLoader doesn't work anymore after changes for Modify Ticket infrastructure

DescriptionCurrently the concurrency check in the OrderLoader doesn't work anymore after changes done to the concurrency check code itself. These changes came from the Modify Ticket infrastructure project.
Steps To Reproduce- Create a layaway in the WebPOS.
- Log in two terminals at the same time. Load the layaway in both.
- Pay the layaway fully in one terminal.
- Pay the layaway fully in the second one.
- Go to errors while importing. Notice that the second one failed, but not because of the concurrency check. If you debug in Eclipse, you will notice that the check is currently not executed.
Proposed SolutionThe check should be executed when using modify ticket, but also if the ticket already exists in general.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0037830 closedjorge-garcia Concurrency check in the OrderLoader doesn't work anymore after changes for Modify Ticket infrastructure 

-  Notes
(0103931)
hgbot (developer)
2018-04-17 12:26

 Repository: retail/backports/3.0RR18Q1.2/org.openbravo.retail.posterminal
Changeset: 7915eaa1481b7e289da3a603f14b4818f271516c
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Apr 17 12:25:24 2018 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR18Q1.2/org.openbravo.retail.posterminal/rev/7915eaa1481b7e289da3a603f14b4818f271516c [^]

Fixed issue 37832: Concurrency check in the OrderLoader doesn't work anymore
after changes for Modify Ticket infrastructure

The solution is to do a outdated check always, not only for modified tickets.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---

- Issue History
Date Modified Username Field Change
2018-02-05 12:07 marvintm Type defect => backport
2018-02-05 12:07 marvintm Target Version => RR18Q1
2018-02-13 16:46 marvintm Target Version RR18Q1 => RR18Q1.1
2018-03-15 09:48 marvintm Target Version RR18Q1.1 => RR18Q1.2
2018-04-17 08:59 marvintm Regression level => Production - QA Approved
2018-04-17 08:59 marvintm Regression date => 2017-11-22
2018-04-17 08:59 marvintm Regression introduced in release => RR18Q1
2018-04-17 08:59 marvintm Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a2186d120ffa [^]
2018-04-17 12:26 hgbot Checkin
2018-04-17 12:26 hgbot Note Added: 0103931
2018-04-17 12:26 hgbot Status scheduled => resolved
2018-04-17 12:26 hgbot Resolution open => fixed
2018-04-17 12:26 hgbot Fixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR18Q1.2/org.openbravo.retail.posterminal/rev/7915eaa1481b7e289da3a603f14b4818f271516c [^]
2018-04-18 11:14 marvintm Review Assigned To => marvintm
2018-04-18 11:14 marvintm Status resolved => closed
2018-04-18 11:14 marvintm Fixed in Version => RR18Q1.2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker