Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0037830
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2018-02-05 12:042018-04-18 15:53
ReportermarvintmView Statuspublic 
Assigned Tojorge-garcia 
PriorityurgentResolutionfixedFixed in VersionRR18Q3
StatusclosedFix in branchFixed in SCM revision6f63d5ece973
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression levelProduction - QA Approved
Regression date2017-11-22
Regression introduced in releaseRR18Q1
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a2186d120ffa [^]
Triggers an Emergency PackNo
Summary

0037830: Concurrency check in the OrderLoader doesn't work anymore after changes for Modify Ticket infrastructure

DescriptionCurrently the concurrency check in the OrderLoader doesn't work anymore after changes done to the concurrency check code itself. These changes came from the Modify Ticket infrastructure project.
Steps To Reproduce- Create a layaway in the WebPOS.
- Log in two terminals at the same time. Load the layaway in both.
- Pay the layaway fully in one terminal.
- Pay the layaway fully in the second one.
- Go to errors while importing. Notice that the second one failed, but not because of the concurrency check. If you debug in Eclipse, you will notice that the check is currently not executed.
Proposed SolutionThe check should be executed when using modify ticket, but also if the ticket already exists in general.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 0037832RR18Q1.2 closedRetail Concurrency check in the OrderLoader doesn't work anymore after changes for Modify Ticket infrastructure 
depends on backport 0038385RR18Q2 closedRetail Concurrency check in the OrderLoader doesn't work anymore after changes for Modify Ticket infrastructure 

-  Notes
(0103968)
hgbot (developer)
2018-04-18 12:51

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6f63d5ece9734303aac13e2f48ab1c8a7115f269
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Apr 17 12:19:43 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6f63d5ece9734303aac13e2f48ab1c8a7115f269 [^]

Fixed issue 37830: Concurrency check in the OrderLoader doesn't work anymore
after changes for Modify Ticket infrastructure

The solution is to do a outdated check always, not only for modified tickets.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---

- Issue History
Date Modified Username Field Change
2018-02-05 12:04 marvintm New Issue
2018-02-05 12:04 marvintm Assigned To => Retail
2018-02-05 12:04 marvintm Triggers an Emergency Pack => No
2018-02-05 12:07 marvintm Status new => scheduled
2018-04-17 09:03 marvintm Regression level => Production - QA Approved
2018-04-17 09:03 marvintm Regression date => 2017-11-22
2018-04-17 09:03 marvintm Regression introduced in release => RR18Q1
2018-04-17 09:03 marvintm Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a2186d120ffa [^]
2018-04-17 09:04 marvintm Status scheduled => acknowledged
2018-04-17 09:04 marvintm Status acknowledged => scheduled
2018-04-17 09:18 umartirena Issue Monitored: umartirena
2018-04-17 09:20 martinsdan Issue Monitored: martinsdan
2018-04-17 12:18 jorge-garcia Assigned To Retail => jorge-garcia
2018-04-18 12:51 hgbot Checkin
2018-04-18 12:51 hgbot Note Added: 0103968
2018-04-18 12:51 hgbot Status scheduled => resolved
2018-04-18 12:51 hgbot Resolution open => fixed
2018-04-18 12:51 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6f63d5ece9734303aac13e2f48ab1c8a7115f269 [^]
2018-04-18 15:53 marvintm Review Assigned To => marvintm
2018-04-18 15:53 marvintm Status resolved => closed
2018-04-18 15:53 marvintm Fixed in Version => RR18Q3


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker