Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037830Retail ModulesWeb POSpublic2018-02-05 12:042018-04-18 15:53
Reportermarvintm 
Assigned Tojorge-garcia 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression levelProduction - QA Approved
Regression date2017-11-22
Regression introduced in releaseRR18Q1
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a2186d120ffa [^]
Triggers an Emergency PackNo
Summary0037830: Concurrency check in the OrderLoader doesn't work anymore after changes for Modify Ticket infrastructure
DescriptionCurrently the concurrency check in the OrderLoader doesn't work anymore after changes done to the concurrency check code itself. These changes came from the Modify Ticket infrastructure project.
Steps To Reproduce- Create a layaway in the WebPOS.
- Log in two terminals at the same time. Load the layaway in both.
- Pay the layaway fully in one terminal.
- Pay the layaway fully in the second one.
- Go to errors while importing. Notice that the second one failed, but not because of the concurrency check. If you debug in Eclipse, you will notice that the check is currently not executed.
Proposed SolutionThe check should be executed when using modify ticket, but also if the ticket already exists in general.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0037832RR18Q1.2 closed Retail Concurrency check in the OrderLoader doesn't work anymore after changes for Modify Ticket infrastructure 
depends on backport 0038385RR18Q2 closed Retail Concurrency check in the OrderLoader doesn't work anymore after changes for Modify Ticket infrastructure 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-02-05 12:04marvintmNew Issue
2018-02-05 12:04marvintmAssigned To => Retail
2018-02-05 12:04marvintmOBNetwork customer => No
2018-02-05 12:04marvintmTriggers an Emergency Pack => No
2018-02-05 12:07marvintmStatusnew => scheduled
2018-04-17 09:03marvintmRegression level => Production - QA Approved
2018-04-17 09:03marvintmRegression date => 2017-11-22
2018-04-17 09:03marvintmRegression introduced in release => RR18Q1
2018-04-17 09:03marvintmRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a2186d120ffa [^]
2018-04-17 09:04marvintmStatusscheduled => acknowledged
2018-04-17 09:04marvintmStatusacknowledged => scheduled
2018-04-17 09:18umartirenaIssue Monitored: umartirena
2018-04-17 09:20martinsdanIssue Monitored: martinsdan
2018-04-17 12:18jorge-garciaAssigned ToRetail => jorge-garcia
2018-04-18 12:51hgbotCheckin
2018-04-18 12:51hgbotNote Added: 0103968
2018-04-18 12:51hgbotStatusscheduled => resolved
2018-04-18 12:51hgbotResolutionopen => fixed
2018-04-18 12:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6f63d5ece9734303aac13e2f48ab1c8a7115f269 [^]
2018-04-18 15:53marvintmReview Assigned To => marvintm
2018-04-18 15:53marvintmStatusresolved => closed
2018-04-18 15:53marvintmFixed in Version => RR18Q3

Notes
(0103968)
hgbot   
2018-04-18 12:51   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6f63d5ece9734303aac13e2f48ab1c8a7115f269
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Apr 17 12:19:43 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6f63d5ece9734303aac13e2f48ab1c8a7115f269 [^]

Fixed issue 37830: Concurrency check in the OrderLoader doesn't work anymore
after changes for Modify Ticket infrastructure

The solution is to do a outdated check always, not only for modified tickets.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---