Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037832Retail ModulesWeb POSpublic2018-02-05 12:042018-04-18 11:14
Reportermarvintm 
Assigned ToRetail 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR18Q1.2Fixed in VersionRR18Q1.2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression levelProduction - QA Approved
Regression date2017-11-22
Regression introduced in releaseRR18Q1
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a2186d120ffa [^]
Triggers an Emergency PackNo
Summary0037832: Concurrency check in the OrderLoader doesn't work anymore after changes for Modify Ticket infrastructure
DescriptionCurrently the concurrency check in the OrderLoader doesn't work anymore after changes done to the concurrency check code itself. These changes came from the Modify Ticket infrastructure project.
Steps To Reproduce- Create a layaway in the WebPOS.
- Log in two terminals at the same time. Load the layaway in both.
- Pay the layaway fully in one terminal.
- Pay the layaway fully in the second one.
- Go to errors while importing. Notice that the second one failed, but not because of the concurrency check. If you debug in Eclipse, you will notice that the check is currently not executed.
Proposed SolutionThe check should be executed when using modify ticket, but also if the ticket already exists in general.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0037830 closed jorge-garcia Concurrency check in the OrderLoader doesn't work anymore after changes for Modify Ticket infrastructure 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-02-05 12:07marvintmTypedefect => backport
2018-02-05 12:07marvintmTarget Version => RR18Q1
2018-02-13 16:46marvintmTarget VersionRR18Q1 => RR18Q1.1
2018-03-15 09:48marvintmTarget VersionRR18Q1.1 => RR18Q1.2
2018-04-17 08:59marvintmRegression level => Production - QA Approved
2018-04-17 08:59marvintmRegression date => 2017-11-22
2018-04-17 08:59marvintmRegression introduced in release => RR18Q1
2018-04-17 08:59marvintmRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a2186d120ffa [^]
2018-04-17 12:26hgbotCheckin
2018-04-17 12:26hgbotNote Added: 0103931
2018-04-17 12:26hgbotStatusscheduled => resolved
2018-04-17 12:26hgbotResolutionopen => fixed
2018-04-17 12:26hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR18Q1.2/org.openbravo.retail.posterminal/rev/7915eaa1481b7e289da3a603f14b4818f271516c [^]
2018-04-18 11:14marvintmReview Assigned To => marvintm
2018-04-18 11:14marvintmStatusresolved => closed
2018-04-18 11:14marvintmFixed in Version => RR18Q1.2

Notes
(0103931)
hgbot   
2018-04-17 12:26   
Repository: retail/backports/3.0RR18Q1.2/org.openbravo.retail.posterminal
Changeset: 7915eaa1481b7e289da3a603f14b4818f271516c
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Apr 17 12:25:24 2018 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR18Q1.2/org.openbravo.retail.posterminal/rev/7915eaa1481b7e289da3a603f14b4818f271516c [^]

Fixed issue 37832: Concurrency check in the OrderLoader doesn't work anymore
after changes for Modify Ticket infrastructure

The solution is to do a outdated check always, not only for modified tickets.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---