Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0037495
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2017-12-16 14:172017-12-17 17:45
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in VersionRR18Q1
StatusclosedFix in branchFixed in SCM revisiona9628e4ed192
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0037495: Remove never read variables from pl code

DescriptionRetail code has a few variables in pl code which are written into but never read.

> Remove those
Steps To Reproducerun plpgsql_check (>=1.2.2)
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0037481 closedshuehner Openbravo ERP unused PL variables - platform 

-  Notes
(0101082)
hgbot (developer)
2017-12-16 14:35

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f1c6e96386f90770308c8b087a48a07443bcdcf1
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sat Dec 16 14:28:30 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f1c6e96386f90770308c8b087a48a07443bcdcf1 [^]

Issue 37495: Remove never read variables from pl code

---
M src-db/database/model/triggers/OBPOS_PRINT_TEMPLATE_MOD_TRG.xml
---
(0101083)
hgbot (developer)
2017-12-16 14:35

Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: a9628e4ed19282dec8f522362a99f07ec2400739
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sat Dec 16 14:30:21 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/a9628e4ed19282dec8f522362a99f07ec2400739 [^]

Fixed 37495. Remove never read variable from pl code.

- kk variable was just never read at all (found by plpgsql_check)
- v_x variable is used several times
  - However last write into that variable by running some sql is useless
  - as it is done at end of function and then never used (found manually)

---
M src-db/database/model/functions/OBDISC_PACK.xml
---

- Issue History
Date Modified Username Field Change
2017-12-16 14:17 shuehner New Issue
2017-12-16 14:17 shuehner Assigned To => shuehner
2017-12-16 14:17 shuehner Triggers an Emergency Pack => No
2017-12-16 14:17 shuehner Relationship added related to 0037481
2017-12-16 14:35 hgbot Checkin
2017-12-16 14:35 hgbot Note Added: 0101082
2017-12-16 14:35 hgbot Checkin
2017-12-16 14:35 hgbot Note Added: 0101083
2017-12-16 14:35 hgbot Status new => resolved
2017-12-16 14:35 hgbot Resolution open => fixed
2017-12-16 14:35 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/a9628e4ed19282dec8f522362a99f07ec2400739 [^]
2017-12-16 14:36 shuehner Review Assigned To => marvintm
2017-12-17 17:45 marvintm Status resolved => closed
2017-12-17 17:45 marvintm Fixed in Version => RR18Q1


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker