Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037495Retail ModulesWeb POSpublic2017-12-16 14:172017-12-17 17:45
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037495: Remove never read variables from pl code
DescriptionRetail code has a few variables in pl code which are written into but never read.

> Remove those
Steps To Reproducerun plpgsql_check (>=1.2.2)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0037481 closed shuehner Openbravo ERP unused PL variables - platform 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-12-16 14:17shuehnerNew Issue
2017-12-16 14:17shuehnerAssigned To => shuehner
2017-12-16 14:17shuehnerTriggers an Emergency Pack => No
2017-12-16 14:17shuehnerRelationship addedrelated to 0037481
2017-12-16 14:35hgbotCheckin
2017-12-16 14:35hgbotNote Added: 0101082
2017-12-16 14:35hgbotCheckin
2017-12-16 14:35hgbotNote Added: 0101083
2017-12-16 14:35hgbotStatusnew => resolved
2017-12-16 14:35hgbotResolutionopen => fixed
2017-12-16 14:35hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/a9628e4ed19282dec8f522362a99f07ec2400739 [^]
2017-12-16 14:36shuehnerReview Assigned To => marvintm
2017-12-17 17:45marvintmStatusresolved => closed
2017-12-17 17:45marvintmFixed in Version => RR18Q1

Notes
(0101082)
hgbot   
2017-12-16 14:35   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f1c6e96386f90770308c8b087a48a07443bcdcf1
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sat Dec 16 14:28:30 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f1c6e96386f90770308c8b087a48a07443bcdcf1 [^]

Issue 37495: Remove never read variables from pl code

---
M src-db/database/model/triggers/OBPOS_PRINT_TEMPLATE_MOD_TRG.xml
---
(0101083)
hgbot   
2017-12-16 14:35   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: a9628e4ed19282dec8f522362a99f07ec2400739
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sat Dec 16 14:30:21 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/a9628e4ed19282dec8f522362a99f07ec2400739 [^]

Fixed 37495. Remove never read variable from pl code.

- kk variable was just never read at all (found by plpgsql_check)
- v_x variable is used several times
  - However last write into that variable by running some sql is useless
  - as it is done at end of function and then never used (found manually)

---
M src-db/database/model/functions/OBDISC_PACK.xml
---