Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036253
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2017-06-14 12:282017-07-28 13:58
ReportermalsasuaView Statuspublic 
Assigned Tomigueldejuana 
PriorityimmediateResolutionfixedFixed in VersionRR17Q3
StatusclosedFix in branchFixed in SCM revisionc6f304688ad8
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036253: cashup is creating wrong invoices when receipt delivered location is changed

Descriptionif one cashup has got two receipts, with the same bill address but different ship address, when cashup is done, two invoices are created with wrong lines
Steps To Reproducein POS:
. new receipt:
  . bill address: address1
  . delivered address: address1
  . line 1: l1: amount 10
  . total receipt 10
. new receipt:
  . bill address: address1
  . delivered address: address2
  . line 1: l2: amount 5
  . total receipt 5
. do cashup
in backoffice:
two invoices have been created:
. invoice1: total amount 10 -> sum total lines: 15
. invoice2: total amount 5 -> sum total lines: 15
Proposed Solutionin this line:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/7ad10cf2a983/src/org/openbravo/retail/posterminal/OrderGroupingProcessor_data.xsql#l53 [^]

modify by:
 o.c_bpartner_id, o.billto_id, o.c_currency_id, bp.paymentrule,
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0036255RR17Q2.1 closedRetail cashup is creating wrong invoices when receipt delivered location is changed 
depends on backport 0036256RR17Q1.2 closedmigueldejuana cashup is creating wrong invoices when receipt delivered location is changed 
related to defect 0034084 newRetail Pending test to be developed 

-  Notes
(0097397)
hgbot (developer)
2017-06-14 17:41

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c6f304688ad8e1ebe4618e3735a307fa27ed1bb7
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Jun 14 13:12:08 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c6f304688ad8e1ebe4618e3735a307fa27ed1bb7 [^]

Fixed issue 0036253: cashup is creating wrong invoices when receipt delivered location is changed

- Since Web POS allows to set shipping address, we need to take bill addres or if it does not exists, take shipping address when creating cashup grouping invoice

---
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor_data.xsql
---
(0097398)
migueldejuana (developer)
2017-06-14 18:11

 Test performance in cashup. Ensure that the process is still fast
(0097412)
migueldejuana (developer)
2017-06-15 10:42

 Performance in Web POS is not affected because we do not wait for Cashup to be processed. Cashup is processed in the backend but we can keep working in Web POS
(0098261)
hgbot (developer)
2017-07-28 13:57

 Repository: tools/automation/pi-mobile
Changeset: 27c0abe25c5b599d811cfd2b72a7028d01d69491
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Thu Jul 20 16:05:45 2017 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/27c0abe25c5b599d811cfd2b72a7028d01d69491 [^]

Related to issue 36253: cashup is creating wrong invoices when receipt delivered location is changed

Done a test that check when creating two receipts with same invoice address
and different shipping address, don't duplicate the invoice lines between the two invoices

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I36253_CreateTwoReceiptsWithSameInvoiceAddressAndDifferentShippingAddress.java
---
(0098262)
hgbot (developer)
2017-07-28 13:58

 Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: 9035e216e086e5e3d9503841693bb5dfd90c56c8
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Thu Jul 20 13:52:23 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/9035e216e086e5e3d9503841693bb5dfd90c56c8 [^]

Related to issue 36253: cashup is creating wrong invoices when receipt delivered location is changed

Added new shipment address to Arturo Montoro, so there is a bussines partner with 2 addresses
Left disabled to not break other tests, it is enabled and disabled in the test for 36253

---
M referencedata/sampledata/The_White_Valley_Group/C_BPARTNER_LOCATION.xml
M referencedata/sampledata/The_White_Valley_Group/C_LOCATION.xml
---

- Issue History
Date Modified Username Field Change
2017-06-14 12:28 malsasua New Issue
2017-06-14 12:28 malsasua Assigned To => Retail
2017-06-14 12:28 malsasua Resolution time => 1497736800
2017-06-14 12:28 malsasua Triggers an Emergency Pack => No
2017-06-14 13:34 migueldejuana Relationship added related to 0034084
2017-06-14 13:40 migueldejuana Status new => scheduled
2017-06-14 13:40 migueldejuana Assigned To Retail => migueldejuana
2017-06-14 17:41 hgbot Checkin
2017-06-14 17:41 hgbot Note Added: 0097397
2017-06-14 17:41 hgbot Status scheduled => resolved
2017-06-14 17:41 hgbot Resolution open => fixed
2017-06-14 17:41 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c6f304688ad8e1ebe4618e3735a307fa27ed1bb7 [^]
2017-06-14 18:11 migueldejuana Note Added: 0097398
2017-06-15 10:42 migueldejuana Note Added: 0097412
2017-06-19 17:06 marvintm Review Assigned To => marvintm
2017-06-19 17:06 marvintm Status resolved => closed
2017-06-19 17:06 marvintm Fixed in Version => RR17Q3
2017-07-28 13:57 hgbot Checkin
2017-07-28 13:57 hgbot Note Added: 0098261
2017-07-28 13:58 hgbot Checkin
2017-07-28 13:58 hgbot Note Added: 0098262

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker