Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036253Retail ModulesWeb POSpublic2017-06-14 12:282017-07-28 13:58
Reportermalsasua 
Assigned Tomigueldejuana 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036253: cashup is creating wrong invoices when receipt delivered location is changed
Descriptionif one cashup has got two receipts, with the same bill address but different ship address, when cashup is done, two invoices are created with wrong lines
Steps To Reproducein POS:
. new receipt:
  . bill address: address1
  . delivered address: address1
  . line 1: l1: amount 10
  . total receipt 10
. new receipt:
  . bill address: address1
  . delivered address: address2
  . line 1: l2: amount 5
  . total receipt 5
. do cashup
in backoffice:
two invoices have been created:
. invoice1: total amount 10 -> sum total lines: 15
. invoice2: total amount 5 -> sum total lines: 15
Proposed Solutionin this line:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/7ad10cf2a983/src/org/openbravo/retail/posterminal/OrderGroupingProcessor_data.xsql#l53 [^]

modify by:
 o.c_bpartner_id, o.billto_id, o.c_currency_id, bp.paymentrule,
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0036255RR17Q2.1 closed Retail cashup is creating wrong invoices when receipt delivered location is changed 
depends on backport 0036256RR17Q1.2 closed migueldejuana cashup is creating wrong invoices when receipt delivered location is changed 
related to defect 0034084 new Retail Pending test to be developed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-06-14 12:28malsasuaNew Issue
2017-06-14 12:28malsasuaAssigned To => Retail
2017-06-14 12:28malsasuaResolution time => 1497736800
2017-06-14 12:28malsasuaTriggers an Emergency Pack => No
2017-06-14 13:34migueldejuanaRelationship addedrelated to 0034084
2017-06-14 13:40migueldejuanaStatusnew => scheduled
2017-06-14 13:40migueldejuanaAssigned ToRetail => migueldejuana
2017-06-14 17:41hgbotCheckin
2017-06-14 17:41hgbotNote Added: 0097397
2017-06-14 17:41hgbotStatusscheduled => resolved
2017-06-14 17:41hgbotResolutionopen => fixed
2017-06-14 17:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c6f304688ad8e1ebe4618e3735a307fa27ed1bb7 [^]
2017-06-14 18:11migueldejuanaNote Added: 0097398
2017-06-15 10:42migueldejuanaNote Added: 0097412
2017-06-19 17:06marvintmReview Assigned To => marvintm
2017-06-19 17:06marvintmStatusresolved => closed
2017-06-19 17:06marvintmFixed in Version => RR17Q3
2017-07-28 13:57hgbotCheckin
2017-07-28 13:57hgbotNote Added: 0098261
2017-07-28 13:58hgbotCheckin
2017-07-28 13:58hgbotNote Added: 0098262

Notes
(0097397)
hgbot   
2017-06-14 17:41   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c6f304688ad8e1ebe4618e3735a307fa27ed1bb7
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Jun 14 13:12:08 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c6f304688ad8e1ebe4618e3735a307fa27ed1bb7 [^]

Fixed issue 0036253: cashup is creating wrong invoices when receipt delivered location is changed

- Since Web POS allows to set shipping address, we need to take bill addres or if it does not exists, take shipping address when creating cashup grouping invoice

---
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor_data.xsql
---
(0097398)
migueldejuana   
2017-06-14 18:11   
Test performance in cashup. Ensure that the process is still fast
(0097412)
migueldejuana   
2017-06-15 10:42   
Performance in Web POS is not affected because we do not wait for Cashup to be processed. Cashup is processed in the backend but we can keep working in Web POS
(0098261)
hgbot   
2017-07-28 13:57   
Repository: tools/automation/pi-mobile
Changeset: 27c0abe25c5b599d811cfd2b72a7028d01d69491
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Thu Jul 20 16:05:45 2017 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/27c0abe25c5b599d811cfd2b72a7028d01d69491 [^]

Related to issue 36253: cashup is creating wrong invoices when receipt delivered location is changed

Done a test that check when creating two receipts with same invoice address
and different shipping address, don't duplicate the invoice lines between the two invoices

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I36253_CreateTwoReceiptsWithSameInvoiceAddressAndDifferentShippingAddress.java
---
(0098262)
hgbot   
2017-07-28 13:58   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: 9035e216e086e5e3d9503841693bb5dfd90c56c8
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Thu Jul 20 13:52:23 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/9035e216e086e5e3d9503841693bb5dfd90c56c8 [^]

Related to issue 36253: cashup is creating wrong invoices when receipt delivered location is changed

Added new shipment address to Arturo Montoro, so there is a bussines partner with 2 addresses
Left disabled to not break other tests, it is enabled and disabled in the test for 36253

---
M referencedata/sampledata/The_White_Valley_Group/C_BPARTNER_LOCATION.xml
M referencedata/sampledata/The_White_Valley_Group/C_LOCATION.xml
---