0036256: cashup is creating wrong invoices when receipt delivered location is changed

Description

if one cashup has got two receipts, with the same bill address but different ship address, when cashup is done, two invoices are created with wrong lines

Steps To Reproduce

in POS:
. new receipt:
  . bill address: address1
  . delivered address: address1
  . line 1: l1: amount 10
  . total receipt 10
. new receipt:
  . bill address: address1
  . delivered address: address2
  . line 1: l2: amount 5
  . total receipt 5
. do cashup
in backoffice:
two invoices have been created:
. invoice1: total amount 10 -> sum total lines: 15
. invoice2: total amount 5 -> sum total lines: 15

Proposed Solution

in this line:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/7ad10cf2a983/src/org/openbravo/retail/posterminal/OrderGroupingProcessor_data.xsql#l53 [^]

modify by:
o.c_bpartner_id, o.billto_id, o.c_currency_id, bp.paymentrule,

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0036253

closed

migueldejuana

cashup is creating wrong invoices when receipt delivered location is changed

Notes
(0097417) hgbot (developer) 2017-06-15 11:32	Repository: retail/backports/3.0RR17Q1.2/org.openbravo.retail.posterminal Changeset: a6d3f5de08377e2e9db5f125abc3a94d8d951be1 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Thu Jun 15 11:32:34 2017 +0200 URL: http://code.openbravo.com/retail/backports/3.0RR17Q1.2/org.openbravo.retail.posterminal/rev/a6d3f5de08377e2e9db5f125abc3a94d8d951be1 [^] Fixed issue 0036256: cashup is creating wrong invoices when receipt delivered location is changed - Since Web POS allows to set shipping address, we need to take bill addres or if it does not exists, take shipping address when creating cashup grouping invoice --- M src/org/openbravo/retail/posterminal/OrderGroupingProcessor_data.xsql ---

Issue History
Date Modified	Username	Field	Change
2017-06-14 13:40	migueldejuana	Type	defect => backport
2017-06-14 13:40	migueldejuana	Target Version	=> RR17Q1.2
2017-06-15 09:52	jorge-garcia	Assigned To	Retail => migueldejuana
2017-06-15 11:32	hgbot	Checkin
2017-06-15 11:32	hgbot	Note Added: 0097417
2017-06-15 11:32	hgbot	Status	scheduled => resolved
2017-06-15 11:32	hgbot	Resolution	open => fixed
2017-06-15 11:32	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/retail/backports/3.0RR17Q1.2/org.openbravo.retail.posterminal/rev/a6d3f5de08377e2e9db5f125abc3a94d8d951be1 [^]
2017-06-19 17:07	marvintm	Review Assigned To	=> marvintm
2017-06-19 17:07	marvintm	Status	resolved => closed
2017-06-19 17:07	marvintm	Fixed in Version	=> RR17Q1.2