Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036191
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Remittancetrivialhave not tried2017-06-07 13:222017-06-14 16:58
ReporteradrianromeroView Statuspublic 
Assigned Tocollazoandy4 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision72b88bcbbf1c
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Toaferraz
Regression introduced in release
Summary

0036191: Functional validations in REM_RemittanceProcess are logged as exceptions in the log

DescriptionSome functional validations in REM_RemittanceProcess are logged as exceptions in the openbravo log. For example:

https://code.openbravo.com/erp/mods/org.openbravo.module.remittance/file/0bd5fbb29b52/src/org/openbravo/module/remittance/process/REM_RemittanceProcess.java#l225 [^]

But other validations are managed returning an error:

https://code.openbravo.com/erp/mods/org.openbravo.module.remittance/file/0bd5fbb29b52/src/org/openbravo/module/remittance/process/REM_RemittanceProcess.java#l186 [^]

From the functional perspective both validations are managed the same way, an error message is displayed to the user.

This happens not only in this process. Several processes in the application manage functional validations throwing exceptions that are logged in the openbravo log with error level.
Steps To ReproduceGo to the window "Remittance" select one record and press "Process"
Force the code in REM_RemittanceProcess to throw an exception
Verify an error message is displayed to the user and the exception is logged.
Proposed SolutionReturn an OBError result instead of throwing an exception.
TagsSER-QA
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on defect 00314513.0PR16Q1 closedaferraz Openbravo ERP Error should not be logged in case we throw an OBException with logException parameter as false 
blocks design defect 0036162 acknowledgedTriage Platform Base Openbravo ERP clean up openbravo.log 

-  Notes
(0097341)
aferraz (manager)
2017-06-13 09:30

 Moved to Trivial:

As we don't have a clear logging guidelines right now, this kind of issues can not be considered as real defects.
Product team will check if it makes sense to fix it or not.
(0097367)
aferraz (manager)
2017-06-13 17:42

 Possible solution:

Add logException parameter = false when creating OBException.
(0097392)
collazoandy4 (reporter)
2017-06-14 15:53

 Test Plan
  Go to the Remittance window and select one record and clic on Process button
  Force the code in REM_RemittanceProcess to throw an exception and check no error is logged.
(0097394)
hgbot (developer)
2017-06-14 16:56

 Repository: erp/mods/org.openbravo.module.remittance
Changeset: 72b88bcbbf1c94a3778f7bac821f8c0c47dc30f1
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Tue Jun 13 23:36:25 2017 -0400
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/72b88bcbbf1c94a3778f7bac821f8c0c47dc30f1 [^]

Fixes issue 36191: Avoid logging functional validations in REM_RemittanceProcess

Some functional validations in REM_RemittanceProcess are logged as exceptions in
the openbravo log.

Now the exceptions use the logException param indicating that no log is required
for this exception.

---
M src/org/openbravo/module/remittance/process/REM_RemittanceProcess.java
---
(0097395)
hgbot (developer)
2017-06-14 16:56

 Repository: erp/mods/org.openbravo.module.remittance
Changeset: 4715f5a76dc6cc6f397d71c95ae728b66219139a
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Jun 14 16:52:02 2017 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/4715f5a76dc6cc6f397d71c95ae728b66219139a [^]

Related to issue 36191: Update module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0097396)
aferraz (manager)
2017-06-14 16:56

 Code review OK

- Issue History
Date Modified Username Field Change
2017-06-07 13:22 adrianromero New Issue
2017-06-07 13:22 adrianromero Assigned To => Triage Finance
2017-06-07 13:22 adrianromero Modules => Core
2017-06-07 13:22 adrianromero Resolution time => 1497996000
2017-06-07 13:22 adrianromero Triggers an Emergency Pack => No
2017-06-07 13:23 adrianromero Tag Attached: SER-QA
2017-06-07 13:24 adrianromero Modules Core => Advanced Payables and Receivables Mngmt
2017-06-07 13:45 aferraz Project Openbravo ERP => Modules
2017-06-07 13:45 aferraz Category 09. Financial management => Remittance
2017-06-08 12:47 alostale Relationship added blocks 0036162
2017-06-13 09:30 aferraz Note Added: 0097341
2017-06-13 09:30 aferraz Severity major => trivial
2017-06-13 17:42 aferraz Note Added: 0097367
2017-06-14 15:52 collazoandy4 Status new => scheduled
2017-06-14 15:53 collazoandy4 Assigned To Triage Finance => collazoandy4
2017-06-14 15:53 collazoandy4 Note Added: 0097392
2017-06-14 16:56 hgbot Checkin
2017-06-14 16:56 hgbot Note Added: 0097394
2017-06-14 16:56 hgbot Status scheduled => resolved
2017-06-14 16:56 hgbot Resolution open => fixed
2017-06-14 16:56 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/72b88bcbbf1c94a3778f7bac821f8c0c47dc30f1 [^]
2017-06-14 16:56 hgbot Checkin
2017-06-14 16:56 hgbot Note Added: 0097395
2017-06-14 16:56 aferraz Review Assigned To => aferraz
2017-06-14 16:56 aferraz Note Added: 0097396
2017-06-14 16:56 aferraz Status resolved => closed
2017-06-14 16:58 aferraz Relationship added depends on 0031451

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker