0036191: Functional validations in REM_RemittanceProcess are logged as exceptions in the log

Openbravo Issue Tracking System - Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0036191

Modules

Remittance

public

2017-06-07 13:22

2017-06-14 16:58

Reporter

adrianromero

Assigned To

collazoandy4

Priority

urgent

Severity

trivial

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Regression date

Regression introduced by commit

Regression level

Review Assigned To

aferraz

Support ticket

OBNetwork customer

Regression introduced in release

Summary

0036191: Functional validations in REM_RemittanceProcess are logged as exceptions in the log

Description

Some functional validations in REM_RemittanceProcess are logged as exceptions in the openbravo log. For example:

https://code.openbravo.com/erp/mods/org.openbravo.module.remittance/file/0bd5fbb29b52/src/org/openbravo/module/remittance/process/REM_RemittanceProcess.java#l225 [^]

But other validations are managed returning an error:

https://code.openbravo.com/erp/mods/org.openbravo.module.remittance/file/0bd5fbb29b52/src/org/openbravo/module/remittance/process/REM_RemittanceProcess.java#l186 [^]

From the functional perspective both validations are managed the same way, an error message is displayed to the user.

This happens not only in this process. Several processes in the application manage functional validations throwing exceptions that are logged in the openbravo log with error level.

Steps To Reproduce

Go to the window "Remittance" select one record and press "Process"
Force the code in REM_RemittanceProcess to throw an exception
Verify an error message is displayed to the user and the exception is logged.

Proposed Solution

Return an OBError result instead of throwing an exception.

Additional Information

Tags

SER-QA

Relationships

depends on	defect	0031451	3.0PR16Q1	closed	aferraz	Openbravo ERP	Error should not be logged in case we throw an OBException with logException parameter as false
blocks	design defect	0036162		acknowledged	Triage Platform Base	Openbravo ERP	clean up openbravo.log