Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0031451 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | always | 2015-11-12 12:53 | 2015-12-09 16:27 | |||
| Reporter | aferraz | View Status | public | |||||
| Assigned To | aferraz | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR16Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 425220984e4e | ||||
| Projection | none | ETA | none | Target Version | 3.0PR16Q1 | |||
| OS | Linux 64 bit | Database | PostgreSQL | Java version | 1.6.0_18 | |||
| OS Version | Professional Appliance | Database version | 8.3.9 | Ant version | 1.7.1 | |||
| Product Version | SCM revision | |||||||
| Review Assigned To | alostale | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0031451: Error should not be logged in case we throw an OBException with logException parameter as false | |||||||
| Description | In case we throw an OBException from an Event Handler calling OBException(String message, Throwable cause, boolean logException) method with logException parameter as false, error will be raised in the log by DefaultDataSourceService.update method (line 833), while it should not. | |||||||
| Steps To Reproduce | - In FIN_FinaccTransactionEventListener class, validateTransactionType method, line 82, change the following line: throw new OBException("@APRM_INVALID_TRANSACTION@"); into this one: throw new OBException("@APRM_INVALID_TRANSACTION@", null, false); As F&B Admin: - Select Cuenta de Banco Financial Account Create a new record in Transaction tab, but do not change any field. Click on Save button. Realize @APRM_INVALID_TRANSACTION@ error is shown in the log, although you have thrown it with logException as false: org.openbravo.base.exception.OBException: @APRM_INVALID_TRANSACTION@ | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||||||||||||
|
|||||||||||||||||||||||||
 Relationships |
|
Notes |
|
|
(0081758) hgbot (developer) 2015-11-12 14:36 |
Repository: erp/devel/pi Changeset: 425220984e4ed06edc7f21c3963f617c3aee2a0c Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Thu Nov 12 13:02:15 2015 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/425220984e4ed06edc7f21c3963f617c3aee2a0c [^] Fixes issue 31451: OBException logged when it should not DefaultJsonDataService will check if it is needed to log localThrowable exception, in case it is an OBException. New method added in OBException to allow throw exceptions without throwable cause and without log them. --- M modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java M src/org/openbravo/base/exception/OBException.java --- |
|
(0081888) alostale (manager) 2015-11-16 14:39 |
code reviewed |
|
(0082210) hudsonbot (developer) 2015-11-23 21:17 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-11-12 12:53 | aferraz | New Issue | |
| 2015-11-12 12:53 | aferraz | Assigned To | => aferraz |
| 2015-11-12 12:53 | aferraz | Modules | => Core |
| 2015-11-12 12:53 | aferraz | Triggers an Emergency Pack | => No |
| 2015-11-12 12:54 | aferraz | Status | new => scheduled |
| 2015-11-12 12:54 | aferraz | Review Assigned To | => alostale |
| 2015-11-12 14:36 | hgbot | Checkin | |
| 2015-11-12 14:36 | hgbot | Note Added: 0081758 | |
| 2015-11-12 14:36 | hgbot | Status | scheduled => resolved |
| 2015-11-12 14:36 | hgbot | Resolution | open => fixed |
| 2015-11-12 14:36 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/425220984e4ed06edc7f21c3963f617c3aee2a0c [^] |
| 2015-11-12 14:43 | aferraz | Relationship added | blocks 0031452 |
| 2015-11-16 14:39 | alostale | Note Added: 0081888 | |
| 2015-11-16 14:39 | alostale | Status | resolved => closed |
| 2015-11-16 14:39 | alostale | Fixed in Version | => 3.0PR16Q1 |
| 2015-11-23 21:17 | hudsonbot | Checkin | |
| 2015-11-23 21:17 | hudsonbot | Note Added: 0082210 | |
| 2015-12-09 16:27 | alostale | Relationship added | related to 0031674 |
| 2017-06-14 16:58 | aferraz | Relationship added | blocks 0036191 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |