Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0035873 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | always | 2017-04-28 10:20 | 2017-05-29 17:43 | |||
| Reporter | caristu | View Status | public | |||||
| Assigned To | inigosanchez | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | 3.0PR17Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | f1ca59efe2f2 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | caristu | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | Pre packaging ( pi ) | |||||||
| Regression date | 2017-04-21 | |||||||
| Regression introduced in release | pi | |||||||
| Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/bcf679ab26bb68d6e390d0d443c36349811b2918 [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0035873: On change functions not executed for numeric parameters | |||||||
| Description | Due to the following changeset[1], on change functions are not being executed for numeric parameters. In this case the view is not retrieved properly, causing an exception because in that case we are trying to read a property from an undefined value. Detected due to the failure of the following jobs in CI[2],[3],[4] [1] https://code.openbravo.com/erp/devel/pi/rev/bcf679ab26bb68d6e390d0d443c36349811b2918 [^] [2] http://ci.openbravo.com/view/qa/job/qa-pi-addpayment-pgsql/743/ [^] [3] http://ci.openbravo.com/view/qa/job/qa-pi-aprinreg-pgsql/719/ [^] [4] http://ci.openbravo.com/view/qa/job/qa-pi-salproreg-pgsql/725/ [^] | |||||||
| Steps To Reproduce | 1) Go to the [Payment In] window 2) Create a new record 3) Click in Add Details 4) Enter a value in the "Actual Payment" parameter and move outside to launch the execution of its on change function. It should update the value of the "There is a difference field" --> ERROR: not being updated because the on change function is not fired. | |||||||
| Proposed Solution | The fix for issue 0035658 does not take into account numeric fields in P&E windows which are out of a parameter grid. See attached path with the proposed solution. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  issue35873.diff [^] (875 bytes) 2017-04-28 10:26 [Show Content]
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||||||||||||||||
|
|||||||||||||||||||||||||||||
 Relationships |
|
Notes |
|
|
(0096264) hgbot (developer) 2017-04-28 13:12 |
Repository: erp/devel/pi Changeset: f1ca59efe2f24f6d6115e11664bd3ba1f5a5a874 Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com> Date: Fri Apr 28 13:11:39 2017 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/f1ca59efe2f24f6d6115e11664bd3ba1f5a5a874 [^] Fixed issue 35873: On change functions not executed for numeric parameters The problem was that on change functions was not executed for numeric parameters. This problem was caused by the partial fix of 0035658 regression. The fix of 0035658 was partial because the added condition did not taken into account numeric fields in P&E windows which are out of a parameter grid. This problem has been resolved by take into account this case. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-number.js --- |
|
(0096267) caristu (developer) 2017-04-28 13:36 |
Code review + testing OK. |
|
(0096917) hudsonbot (developer) 2017-05-29 17:43 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-04-28 10:20 | caristu | New Issue | |
| 2017-04-28 10:20 | caristu | Assigned To | => platform |
| 2017-04-28 10:20 | caristu | Modules | => Core |
| 2017-04-28 10:20 | caristu | Regression level | => Pre packaging ( pi ) |
| 2017-04-28 10:20 | caristu | Regression date | => 2017-04-21 |
| 2017-04-28 10:20 | caristu | Regression introduced in release | => pi |
| 2017-04-28 10:20 | caristu | Regression introduced by commit | => https://code.openbravo.com/erp/devel/pi/rev/bcf679ab26bb68d6e390d0d443c36349811b2918 [^] |
| 2017-04-28 10:20 | caristu | Triggers an Emergency Pack | => No |
| 2017-04-28 10:26 | caristu | Description Updated | View Revisions |
| 2017-04-28 10:26 | caristu | Proposed Solution updated | |
| 2017-04-28 10:26 | caristu | File Added: issue35873.diff | |
| 2017-04-28 10:50 | caristu | Assigned To | platform => inigosanchez |
| 2017-04-28 10:51 | caristu | Reproducibility | have not tried => always |
| 2017-04-28 11:20 | caristu | Relationship added | caused by 0035658 |
| 2017-04-28 11:32 | inigosanchez | Status | new => acknowledged |
| 2017-04-28 11:36 | inigosanchez | Status | acknowledged => scheduled |
| 2017-04-28 11:42 | inigosanchez | Review Assigned To | => alostale |
| 2017-04-28 12:48 | inigosanchez | Review Assigned To | alostale => caristu |
| 2017-04-28 13:12 | hgbot | Checkin | |
| 2017-04-28 13:12 | hgbot | Note Added: 0096264 | |
| 2017-04-28 13:12 | hgbot | Status | scheduled => resolved |
| 2017-04-28 13:12 | hgbot | Resolution | open => fixed |
| 2017-04-28 13:12 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/f1ca59efe2f24f6d6115e11664bd3ba1f5a5a874 [^] |
| 2017-04-28 13:36 | caristu | Note Added: 0096267 | |
| 2017-04-28 13:36 | caristu | Status | resolved => closed |
| 2017-04-28 13:36 | caristu | Fixed in Version | => 3.0PR17Q3 |
| 2017-05-29 17:43 | hudsonbot | Checkin | |
| 2017-05-29 17:43 | hudsonbot | Note Added: 0096917 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |