Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035873Openbravo ERPA. Platformpublic2017-04-28 10:202017-05-29 17:43
Reportercaristu 
Assigned Toinigosanchez 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q3 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelPre packaging ( pi )
Regression date2017-04-21
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/bcf679ab26bb68d6e390d0d443c36349811b2918 [^]
Triggers an Emergency PackNo
Summary0035873: On change functions not executed for numeric parameters
DescriptionDue to the following changeset[1], on change functions are not being executed for numeric parameters. In this case the view is not retrieved properly, causing an exception because in that case we are trying to read a property from an undefined value.

Detected due to the failure of the following jobs in CI[2],[3],[4]

[1] https://code.openbravo.com/erp/devel/pi/rev/bcf679ab26bb68d6e390d0d443c36349811b2918 [^]
[2] http://ci.openbravo.com/view/qa/job/qa-pi-addpayment-pgsql/743/ [^]
[3] http://ci.openbravo.com/view/qa/job/qa-pi-aprinreg-pgsql/719/ [^]
[4] http://ci.openbravo.com/view/qa/job/qa-pi-salproreg-pgsql/725/ [^]
Steps To Reproduce1) Go to the [Payment In] window
2) Create a new record
3) Click in Add Details
4) Enter a value in the "Actual Payment" parameter and move outside to launch the execution of its on change function. It should update the value of the "There is a difference field" --> ERROR: not being updated because the on change function is not fired.
Proposed SolutionThe fix for issue 0035658 does not take into account numeric fields in P&E windows which are out of a parameter grid.

See attached path with the proposed solution.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00358753.0PR17Q2 closed inigosanchez On change functions not executed for numeric parameters 
depends on backport 00358763.0PR17Q1.1 closed inigosanchez On change functions not executed for numeric parameters 
depends on backport 00358773.0PR16Q4.4 closed inigosanchez On change functions not executed for numeric parameters 
caused by defect 0035658 closed inigosanchez Fields redraws in grid view when a numeric field is referenced by a read only logic 
Attached Filesdiff issue35873.diff (875) 2017-04-28 10:26
https://issues.openbravo.com/file_download.php?file_id=10699&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-04-28 10:20caristuNew Issue
2017-04-28 10:20caristuAssigned To => platform
2017-04-28 10:20caristuOBNetwork customer => No
2017-04-28 10:20caristuModules => Core
2017-04-28 10:20caristuRegression level => Pre packaging ( pi )
2017-04-28 10:20caristuRegression date => 2017-04-21
2017-04-28 10:20caristuRegression introduced in release => pi
2017-04-28 10:20caristuRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/bcf679ab26bb68d6e390d0d443c36349811b2918 [^]
2017-04-28 10:20caristuTriggers an Emergency Pack => No
2017-04-28 10:26caristuDescription Updatedbug_revision_view_page.php?rev_id=15077#r15077
2017-04-28 10:26caristuProposed Solution updated
2017-04-28 10:26caristuFile Added: issue35873.diff
2017-04-28 10:50caristuAssigned Toplatform => inigosanchez
2017-04-28 10:51caristuReproducibilityhave not tried => always
2017-04-28 11:20caristuRelationship addedcaused by 0035658
2017-04-28 11:32inigosanchezStatusnew => acknowledged
2017-04-28 11:36inigosanchezStatusacknowledged => scheduled
2017-04-28 11:42inigosanchezReview Assigned To => alostale
2017-04-28 12:48inigosanchezReview Assigned Toalostale => caristu
2017-04-28 13:12hgbotCheckin
2017-04-28 13:12hgbotNote Added: 0096264
2017-04-28 13:12hgbotStatusscheduled => resolved
2017-04-28 13:12hgbotResolutionopen => fixed
2017-04-28 13:12hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f1ca59efe2f24f6d6115e11664bd3ba1f5a5a874 [^]
2017-04-28 13:36caristuNote Added: 0096267
2017-04-28 13:36caristuStatusresolved => closed
2017-04-28 13:36caristuFixed in Version => 3.0PR17Q3
2017-05-29 17:43hudsonbotCheckin
2017-05-29 17:43hudsonbotNote Added: 0096917

Notes
(0096264)
hgbot   
2017-04-28 13:12   
Repository: erp/devel/pi
Changeset: f1ca59efe2f24f6d6115e11664bd3ba1f5a5a874
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Fri Apr 28 13:11:39 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f1ca59efe2f24f6d6115e11664bd3ba1f5a5a874 [^]

Fixed issue 35873: On change functions not executed for numeric parameters

The problem was that on change functions was not executed for numeric parameters.
This problem was caused by the partial fix of 0035658 regression.

The fix of 0035658 was partial because the added condition did not taken into account
numeric fields in P&E windows which are out of a parameter grid. This problem has been
resolved by take into account this case.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-number.js
---
(0096267)
caristu   
2017-04-28 13:36   
Code review + testing OK.
(0096917)
hudsonbot   
2017-05-29 17:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test