0035855: many standard requests borrow more than one connection from DB

(0096252)
alostale (manager)
2017-04-28 10:04

Note it's not possible to get rid of them within a small effort for the 2.50 pages using XmlEngine as a XmlEngine instance is cached per servlet instance. DalConnectionProvider is not thread safe, therefore it's not safe to cache it in XmlEngine.

(0096332)
hgbot (developer)
2017-05-03 10:26

Repository: erp/devel/pi
Changeset: 275afe71cbfd4e1ddd7e1b04671559bd01614af2
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Apr 27 10:18:39 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/275afe71cbfd4e1ddd7e1b04671559bd01614af2 [^]

related to bug 35855: requests borrow more than one connection from DB

Solved Login window + HSAS infrastructure by using only connection obtained
for DAL.

---
M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
M src/org/openbravo/base/secureApp/LoginHandler.java
---

(0096333)
hgbot (developer)
2017-05-03 10:27

Repository: erp/devel/pi
Changeset: 0135d8bfedaa9bd7a801b1b263204f9df50c43d2
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Apr 27 10:48:37 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0135d8bfedaa9bd7a801b1b263204f9df50c43d2 [^]

related to bug 35855: requests borrow more than one connection from DB

Usage audit is now inserted within the same DAL transaction.

---
M src/org/openbravo/erpCommon/security/SessionLogin_data.xsql
M src/org/openbravo/erpCommon/security/UsageAudit.java
---

(0096335)
hgbot (developer)
2017-05-03 10:27

Repository: erp/devel/pi
Changeset: 4c129bcea4c0431d175115ffef48b99457c48449
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Apr 27 14:37:18 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4c129bcea4c0431d175115ffef48b99457c48449 [^]

fixed bug 35855: requests borrow more than one connection from DB

Prevent double connection when generating dynamic js for 2.50 windows

---
M src/org/openbravo/erpCommon/utility/DynamicJS.java
---

(0096337)
hgbot (developer)
2017-05-03 10:27

Repository: erp/devel/pi
Changeset: d19e0b10bb458feda6033d07feccdf384b2374a4
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Apr 27 16:50:24 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d19e0b10bb458feda6033d07feccdf384b2374a4 [^]

fixed bug 35855: requests borrow more than one connection from DB

Some more cases in login

---
M src/org/openbravo/authentication/AuthenticationManager.java
M src/org/openbravo/erpCommon/security/Login.java
---

(0096338)
hgbot (developer)
2017-05-03 10:27

Repository: erp/devel/pi
Changeset: 6d6a1ff11e480d5583f967920da888973ee00575
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Apr 27 17:50:23 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6d6a1ff11e480d5583f967920da888973ee00575 [^]

fixed bug 35855: requests borrow more than one connection from DB

More cases in login page

---
M src/org/openbravo/erpCommon/security/Login.java
---

(0096339)
hgbot (developer)
2017-05-03 10:27

Repository: erp/devel/pi
Changeset: 6fb8997012e9f75a70ee27fbbc8732cc3036d361
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Apr 28 09:37:24 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6fb8997012e9f75a70ee27fbbc8732cc3036d361 [^]

fixed bug 35855: requests borrow more than one connection from DB

  Partially revererted changes in AuthenticationManager. DalConnectionProvider
  is not thread safe, if accessed by 2 threads it is possible T1 to acquire a
  connection that's closed by T2 while still in use by T1.

  So DCP is not cached in AuthenticationManager but cached pool is not used in
  DefaultAuthenticationManger, instead it creates its own DCP in authenticate
  method.

---
M src/org/openbravo/authentication/AuthenticationManager.java
M src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
M src/org/openbravo/service/db/DalConnectionProvider.java
---

(0096340)
hgbot (developer)
2017-05-03 10:27

Repository: erp/devel/pi
Changeset: ae4c54d915ad140aed100163c7975ef0db2eb25a
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue May 02 09:27:56 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ae4c54d915ad140aed100163c7975ef0db2eb25a [^]

fixed bug 35855: requests borrow more than one connection from DB

   Before starting module rebuild through MMC, finalize current transaction to
   release any lock it might have acquired.

   This is now needed because HSAS for this servlet have occurred in the same
   transaction and are still held, before they were already realeased becuase
   they were executed in auto-commit short transactions.

---
M src/org/openbravo/erpCommon/ad_process/ApplyModules.java
---

(0096409)
alostale (manager)
2017-05-05 08:56

Attached screenshot of munin DB connections graph in a real customer with a daily 250 concurrent backoffice users.

(0096417)
alostale (manager)
2017-05-05 12:29
edited on: 2017-05-05 12:30

Note for backports: if backporting this issue to <3.0PR17Q2, take into account it is required to also backport 0035193.

Because now we're reusing the same DAL connection when before a new one was used, it is possible DAL connection to be closed (committed/rolled back) when it's tried to be used by any of these replacements. Therefore DalConnectionProvider.getConnection needs to ensure it is open and if not, create a new one.

(0096466)
hgbot (developer)
2017-05-09 09:27

Repository: erp/devel/pi
Changeset: 426a5270b6a3270eed70c528b8ed9f1feae4dcc4
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue May 09 09:26:35 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/426a5270b6a3270eed70c528b8ed9f1feae4dcc4 [^]

related to bug 35855: requests borrow more than one connection from DB

Reuse connection to use incorrect user/password message

---
M src/org/openbravo/base/secureApp/LoginHandler.java
---

(0096486)
caristu (developer)
2017-05-09 11:52

Reviewed

(0096922)
hudsonbot (developer)
2017-05-29 17:43