Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0035193
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminoralways2017-02-08 09:212017-03-15 20:19
ReportercaristuView Statuspublic 
Assigned Tocaristu 
PriorityimmediateResolutionfixedFixed in Version3.0PR17Q2
StatusclosedFix in branchFixed in SCM revision016e52e2ba89
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression levelPre packaging ( pi )
Regression date2017-01-23
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/84e7958bae798b41046be8e1ed65ab7af1705587 [^]
Triggers an Emergency PackNo
Summary

0035193: Error fired when trying to print and attach a document

DescriptionThe following error is fired after trying to print and attach a document: @CODE=0@PooledConnection has already been closed.
Steps To Reproduce1) Go to the [Sales Order] window
2) Select any record and click on print button in the toolbar
3) On the attach dialog, choose "Yes"
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0032576 closedalostale connection leak when printing Requisition report 
caused by feature request 0034816 closedcaristu Support a second database for reporting 
related to defect 0035356 closedcaristu print & attach doc logs error using (old) commons jdbc pool 
related to defect 0036636 closedalostale new DalConnectionProvider() causes double flush in 1 case 
blocks defect 0035855 closedalostale many standard requests borrow more than one connection from DB 

-  Notes
(0094143)
hgbot (developer)
2017-02-08 10:30

 Repository: erp/devel/pi
Changeset: 016e52e2ba899eea507ff74c22e70ed3024865aa
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Feb 08 10:27:02 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/016e52e2ba899eea507ff74c22e70ed3024865aa [^]

fixes issue 35193: Error fired when trying to print and attach a document

With the changes introduced with the read-only pool project, the reporting engine is making use of the DalConnectionProvider to get information from the database. On the other hand, the fix for issue 0032576 closes the Dal connection to avoid having connection leaks when using Dal from a subreport. Before having the read-only project that fix did not affect to the reporting engine because the PrintController class itself was the connection provider and its connection was not being closed by the subreports using Dal.

But now the same connection provider is used by the PrintController and also by the sub-reports (when they use Dal). For this reason we need to check if the current connection has been closed (by the sub-reports) and in that case, create a new session and return a new connection.

---
M src/org/openbravo/service/db/DalConnectionProvider.java
---
(0094200)
alostale (manager)
2017-02-10 08:09

 code reviewed

tested also there are no leaks as per reported in 0032576
(0095170)
hudsonbot (developer)
2017-03-15 20:19

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2017-02-08 09:21 caristu New Issue
2017-02-08 09:21 caristu Assigned To => caristu
2017-02-08 09:21 caristu Modules => Core
2017-02-08 09:21 caristu Regression level => Pre packaging ( pi )
2017-02-08 09:21 caristu Regression date => 2017-01-23
2017-02-08 09:21 caristu Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/84e7958bae798b41046be8e1ed65ab7af1705587 [^]
2017-02-08 09:21 caristu Triggers an Emergency Pack => No
2017-02-08 09:39 caristu Relationship added caused by 0034816
2017-02-08 09:40 caristu Relationship added related to 0032576
2017-02-08 10:30 hgbot Checkin
2017-02-08 10:30 hgbot Note Added: 0094143
2017-02-08 10:30 hgbot Status new => resolved
2017-02-08 10:30 hgbot Resolution open => fixed
2017-02-08 10:30 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/016e52e2ba899eea507ff74c22e70ed3024865aa [^]
2017-02-08 10:31 caristu Review Assigned To => alostale
2017-02-10 08:09 alostale Note Added: 0094200
2017-02-10 08:09 alostale Status resolved => closed
2017-02-10 08:09 alostale Fixed in Version => 3.0PR17Q2
2017-02-24 10:34 alostale Relationship added related to 0035356
2017-03-15 20:19 hudsonbot Checkin
2017-03-15 20:19 hudsonbot Note Added: 0095170
2017-05-05 12:25 alostale Relationship added blocks 0035855
2017-08-11 12:45 caristu Relationship added related to 0036636

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker