Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0035090
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 04. Warehouse managementminorhave not tried2017-01-30 18:072017-01-31 06:31
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PriorityurgentResolutionfixedFixed in Version3.0PR17Q2
StatusclosedFix in branchFixed in SCM revision1581c71e57c0
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toaferraz
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0035090: Make junit test TestCosting more robust against c_uom.name being directly modified (and not translated via _trl table)

DescriptionWebPOS can currently not read translation for c_uom from c_uom_trl table (that functionality is just missing).

That means in some customer projects c_uom.name is directly modifed/translated to work around that.

However TestCosting in 1 line uses c_uom.name verification by name instead of id.

That should be changed to make the test still work with the name being different.

Note: TestCosting already had a constant UOM_ID for that uom entry just did not use it in one case.
Steps To ReproduceCheck modules job modules-but-qa for the TestCosting that it is confused by the translated c_uom.value.
TagsNo tags attached.
Attached Filesdiff file icon issue-35090.diff [^] (714 bytes) 2017-01-30 18:10 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0035088 closedshuehner Make 2 junit tests more robust against c_country.name being translated directly (not using _trl table) 

-  Notes
(0093947)
hgbot (developer)
2017-01-30 19:47

Repository: erp/devel/pi
Changeset: 1581c71e57c09bc1b6de1276a79c74b069e1b9c0
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Mon Jan 30 19:40:33 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1581c71e57c09bc1b6de1276a79c74b069e1b9c0 [^]

Fixed 35090. Make junit TestCosting more robust.

TestCosting junit test currently fails is c_uom with id = 100 does
not have name=Unit. Test-cost uses the id = 100 already in several
places and only in one does match the expected c_uom entry by name.
Change that one place to check via id to make the test still work
if the name is not Unit.

---
M src-test/src/org/openbravo/test/costing/TestCosting.java
---
(0093951)
aferraz (manager)
2017-01-31 06:31

Code review OK

- Issue History
Date Modified Username Field Change
2017-01-30 18:07 shuehner New Issue
2017-01-30 18:07 shuehner Assigned To => Triage Finance
2017-01-30 18:07 shuehner Modules => Core
2017-01-30 18:07 shuehner Triggers an Emergency Pack => No
2017-01-30 18:09 shuehner Relationship added related to 0035088
2017-01-30 18:10 shuehner File Added: issue-35090.diff
2017-01-30 19:38 shuehner Assigned To Triage Finance => shuehner
2017-01-30 19:38 shuehner Review Assigned To => aferraz
2017-01-30 19:47 hgbot Checkin
2017-01-30 19:47 hgbot Note Added: 0093947
2017-01-30 19:47 hgbot Status new => resolved
2017-01-30 19:47 hgbot Resolution open => fixed
2017-01-30 19:47 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1581c71e57c09bc1b6de1276a79c74b069e1b9c0 [^]
2017-01-31 06:31 aferraz Note Added: 0093951
2017-01-31 06:31 aferraz Status resolved => closed
2017-01-31 06:31 aferraz Fixed in Version => 3.0PR17Q2


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker