Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0035090

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] 04. Warehouse management

minor

have not tried

2017-01-30 18:07

2017-01-31 06:31

Reporter

shuehner

View Status

public

Assigned To

shuehner

Priority

urgent

Resolution

fixed

Fixed in Version

3.0PR17Q2

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

aferraz

OBNetwork customer

No

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0035090: Make junit test TestCosting more robust against c_uom.name being directly modified (and not translated via _trl table)

Description

WebPOS can currently not read translation for c_uom from c_uom_trl table (that functionality is just missing).

That means in some customer projects c_uom.name is directly modifed/translated to work around that.

However TestCosting in 1 line uses c_uom.name verification by name instead of id.

That should be changed to make the test still work with the name being different.

Note: TestCosting already had a constant UOM_ID for that uom entry just did not use it in one case.

Steps To Reproduce

Check modules job modules-but-qa for the TestCosting that it is confused by the translated c_uom.value.

Tags

No tags attached.

issue-35090.diff [^] (714 bytes) 2017-01-30 18:10 [Show Content] [Hide Content]

diff -r 150033493bce src-test/src/org/openbravo/test/costing/TestCosting.java
--- a/src-test/src/org/openbravo/test/costing/TestCosting.java	Mon Jan 23 11:26:31 2017 +0100
+++ b/src-test/src/org/openbravo/test/costing/TestCosting.java	Sun Jan 29 19:46:12 2017 +0100
@@ -12099,7 +12099,7 @@
         assertEquals(physicalInventory.getMaterialMgmtInventoryCountLineList().get(0)
             .getOrderQuantity(), null);
         assertEquals(physicalInventory.getMaterialMgmtInventoryCountLineList().get(0).getUOM()
-            .getName(), "Unit");
+            .getId(), UOM_ID);
         assertEquals(physicalInventory.getMaterialMgmtInventoryCountLineList().get(0)
             .getQuantityOrderBook(), null);

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

closed

Make 2 junit tests more robust against c_country.name being translated directly (not using _trl table)

Notes
(0093947) hgbot (developer) 2017-01-30 19:47	Repository: erp/devel/pi Changeset: 1581c71e57c09bc1b6de1276a79c74b069e1b9c0 Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Mon Jan 30 19:40:33 2017 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/1581c71e57c09bc1b6de1276a79c74b069e1b9c0 [^] Fixed 35090. Make junit TestCosting more robust. TestCosting junit test currently fails is c_uom with id = 100 does not have name=Unit. Test-cost uses the id = 100 already in several places and only in one does match the expected c_uom entry by name. Change that one place to check via id to make the test still work if the name is not Unit. --- M src-test/src/org/openbravo/test/costing/TestCosting.java ---

(0093951) aferraz (viewer) 2017-01-31 06:31	Code review OK

Issue History
Date Modified	Username	Field	Change
2017-01-30 18:07	shuehner	New Issue
2017-01-30 18:07	shuehner	Assigned To	=> Triage Finance
2017-01-30 18:07	shuehner	OBNetwork customer	=> No
2017-01-30 18:07	shuehner	Modules	=> Core
2017-01-30 18:07	shuehner	Triggers an Emergency Pack	=> No
2017-01-30 18:09	shuehner	Relationship added	related to 0035088
2017-01-30 18:10	shuehner	File Added: issue-35090.diff
2017-01-30 19:38	shuehner	Assigned To	Triage Finance => shuehner
2017-01-30 19:38	shuehner	Review Assigned To	=> aferraz
2017-01-30 19:47	hgbot	Checkin
2017-01-30 19:47	hgbot	Note Added: 0093947
2017-01-30 19:47	hgbot	Status	new => resolved
2017-01-30 19:47	hgbot	Resolution	open => fixed
2017-01-30 19:47	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/1581c71e57c09bc1b6de1276a79c74b069e1b9c0 [^]
2017-01-31 06:31	aferraz	Note Added: 0093951
2017-01-31 06:31	aferraz	Status	resolved => closed
2017-01-31 06:31	aferraz	Fixed in Version	=> 3.0PR17Q2

Copyright © 2000 - 2009 MantisBT Group