Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0035088
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2017-01-30 17:432017-02-17 07:36
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PriorityhighResolutionfixedFixed in Version3.0PR17Q2
StatusclosedFix in branchFixed in SCM revisiondbfa5e0628c0
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0035088: Make 2 junit tests more robust against c_country.name being translated directly (not using _trl table)

DescriptionWebPOS currently cannot c_country translation from c_country_trl table.

That means in some customer project c_country.name values are directly modified in the base table.

2 Junit tests currently assume fixed constant names to find some test-data.

Those should be changed to not rely on unmodified name. For example iso-code 2 letter is another unique column which can be used instead.
Steps To ReproduceCheck output of job mod-but-qa modules testing job which has a template or dataset installed doing direct c_country.name edits.
See that 2 platform junit test fail to find their data:
- org.openbravo.test.xml.UniqueConstraintImportTest
- org.openbravo.test.webservice.JSONWebServicesWhereParameter.WebserviceWithWhereParameter

Proposed SolutionChange both test to search by iso-code and not using directly or indirectly the name field.
TagsNo tags attached.
Attached Filesdiff file icon 35088-part1.diff [^] (1,574 bytes) 2017-01-30 17:44 [Show Content]
diff file icon 35088-part2.diff [^] (1,707 bytes) 2017-01-30 17:51 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0035090 closedshuehner Make junit test TestCosting more robust against c_uom.name being directly modified (and not translated via _trl table) 

-  Notes
(0093948)
hgbot (developer)
2017-01-30 20:05

Repository: erp/devel/pi
Changeset: dbfa5e0628c0b4ae39f6e2fdce9fc01e83f463e2
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Mon Jan 30 20:04:43 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/dbfa5e0628c0b4ae39f6e2fdce9fc01e83f463e2 [^]

Fixed 35088. Make 2 junit tests more robust.

Both junit tests assigned that the c_country with _id 106 has the name
"Spain". However in some projects that value is directly modified/translated.
Make the test more robust to search for the country via isocode 'ES' which
is more stable. And in the json test verify the expected row via its id 106
instead of its identifier 'Spain'.

---
M src-test/src/org/openbravo/test/webservice/JSONWebServicesWhereParameter.java
M src-test/src/org/openbravo/test/xml/UniqueConstraintImportTest.java
---
(0094430)
alostale (manager)
2017-02-17 07:36

reviewed

- Issue History
Date Modified Username Field Change
2017-01-30 17:43 shuehner New Issue
2017-01-30 17:43 shuehner Assigned To => platform
2017-01-30 17:43 shuehner Modules => Core
2017-01-30 17:43 shuehner Triggers an Emergency Pack => No
2017-01-30 17:44 shuehner File Added: 35088-part1.diff
2017-01-30 17:51 shuehner File Added: 35088-part2.diff
2017-01-30 18:09 shuehner Relationship added related to 0035090
2017-01-30 20:00 shuehner Assigned To platform => shuehner
2017-01-30 20:00 shuehner Review Assigned To => alostale
2017-01-30 20:05 hgbot Checkin
2017-01-30 20:05 hgbot Note Added: 0093948
2017-01-30 20:05 hgbot Status new => resolved
2017-01-30 20:05 hgbot Resolution open => fixed
2017-01-30 20:05 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/dbfa5e0628c0b4ae39f6e2fdce9fc01e83f463e2 [^]
2017-02-17 07:36 alostale Note Added: 0094430
2017-02-17 07:36 alostale Status resolved => closed
2017-02-17 07:36 alostale Fixed in Version => 3.0PR17Q2


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker