Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0035090Openbravo ERP04. Warehouse managementpublic2017-01-30 18:072017-01-31 06:31
Reportershuehner 
Assigned Toshuehner 
PriorityurgentSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q2 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0035090: Make junit test TestCosting more robust against c_uom.name being directly modified (and not translated via _trl table)
DescriptionWebPOS can currently not read translation for c_uom from c_uom_trl table (that functionality is just missing).

That means in some customer projects c_uom.name is directly modifed/translated to work around that.

However TestCosting in 1 line uses c_uom.name verification by name instead of id.

That should be changed to make the test still work with the name being different.

Note: TestCosting already had a constant UOM_ID for that uom entry just did not use it in one case.
Steps To ReproduceCheck modules job modules-but-qa for the TestCosting that it is confused by the translated c_uom.value.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0035088 closed shuehner Make 2 junit tests more robust against c_country.name being translated directly (not using _trl table) 
Attached Filesdiff issue-35090.diff (714) 2017-01-30 18:10
https://issues.openbravo.com/file_download.php?file_id=10359&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-01-30 18:07shuehnerNew Issue
2017-01-30 18:07shuehnerAssigned To => Triage Finance
2017-01-30 18:07shuehnerOBNetwork customer => No
2017-01-30 18:07shuehnerModules => Core
2017-01-30 18:07shuehnerTriggers an Emergency Pack => No
2017-01-30 18:09shuehnerRelationship addedrelated to 0035088
2017-01-30 18:10shuehnerFile Added: issue-35090.diff
2017-01-30 19:38shuehnerAssigned ToTriage Finance => shuehner
2017-01-30 19:38shuehnerReview Assigned To => aferraz
2017-01-30 19:47hgbotCheckin
2017-01-30 19:47hgbotNote Added: 0093947
2017-01-30 19:47hgbotStatusnew => resolved
2017-01-30 19:47hgbotResolutionopen => fixed
2017-01-30 19:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1581c71e57c09bc1b6de1276a79c74b069e1b9c0 [^]
2017-01-31 06:31aferrazNote Added: 0093951
2017-01-31 06:31aferrazStatusresolved => closed
2017-01-31 06:31aferrazFixed in Version => 3.0PR17Q2

Notes
(0093947)
hgbot   
2017-01-30 19:47   
Repository: erp/devel/pi
Changeset: 1581c71e57c09bc1b6de1276a79c74b069e1b9c0
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Mon Jan 30 19:40:33 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1581c71e57c09bc1b6de1276a79c74b069e1b9c0 [^]

Fixed 35090. Make junit TestCosting more robust.

TestCosting junit test currently fails is c_uom with id = 100 does
not have name=Unit. Test-cost uses the id = 100 already in several
places and only in one does match the expected c_uom entry by name.
Change that one place to check via id to make the test still work
if the name is not Unit.

---
M src-test/src/org/openbravo/test/costing/TestCosting.java
---
(0093951)
aferraz   
2017-01-31 06:31   
Code review OK