Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0034807 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| design defect | [Retail Modules] StoreServer | minor | have not tried | 2016-12-22 10:35 | 2016-12-29 13:22 | |||
| Reporter | mtaal | View Status | public | |||||
| Assigned To | Sandrahuguet | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR17Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 727ec6dd2522 | ||||
| Projection | none | ETA | none | Target Version | RR17Q1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | mtaal | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0034807: [API change] Remove the trigger state field from mobile server definition as the server type (main) provides enough information | |||||||
| Description | The trigger state field (of the Mobile Server Definition table) flag was intended to define that a server's unavailability would trigger going offline or online. However in practice the server type is enough. All the relevant code already uses the utility method [1] checking both the servertype and trigger state. The idea was to support that new server types could trigger offline. But this should be re-implemented whenever this becomes relevant as we then have better knowledge on how it will be used. Also there is already some extension possible for offline checking [2]. [1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/ef3722f7a2bd/src/org/openbravo/mobile/core/servercontroller/MobileServerUtils.java#l41 [^] [2] http://wiki.openbravo.com/wiki/How_to_implement_custom_offline_checking [^] | |||||||
| Steps To Reproduce | Install multi-server | |||||||
| Proposed Solution | Remove the trigger state column and all its usages. Check if the column is used anywhere else than in the above utils method. | |||||||
| Tags | Approved | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0093036) hgbot (developer) 2016-12-28 09:59 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 727ec6dd252256acce4935d1d69654e5339e100c Author: Sandra Huguet <sandra.huguet <at> openbravo.com> Date: Wed Dec 28 09:59:01 2016 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/727ec6dd252256acce4935d1d69654e5339e100c [^] Fixed issue 34807 Remove triggerstate field from mobile server definition --- M src-db/database/model/tables/OBMOBC_SERVER_DEFINITION.xml M src-db/database/sourcedata/AD_COLUMN.xml M src-db/database/sourcedata/AD_ELEMENT.xml M src-db/database/sourcedata/AD_FIELD.xml M src/org/openbravo/mobile/core/servercontroller/MobileMainServerCheck.java M src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java M src/org/openbravo/mobile/core/servercontroller/MobileServerUtils.java --- |
|
(0093052) mtaal (manager) 2016-12-29 13:22 |
Reviewed and tested |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-12-22 10:35 | mtaal | New Issue | |
| 2016-12-22 10:35 | mtaal | Assigned To | => Sandrahuguet |
| 2016-12-22 10:35 | mtaal | Triggers an Emergency Pack | => No |
| 2016-12-22 10:38 | mtaal | Review Assigned To | => mtaal |
| 2016-12-22 10:38 | mtaal | Description Updated | View Revisions |
| 2016-12-27 11:19 | Sandrahuguet | Summary | Remove the trigger state field from mobile server definition as the server type (main) provides enough information => [API change] Remove the trigger state field from mobile server definition as the server type (main) provides enough information |
| 2016-12-27 11:24 | Sandrahuguet | Status | new => scheduled |
| 2016-12-27 19:42 | dmitry_mezentsev | Tag Attached: Approved | |
| 2016-12-28 09:59 | hgbot | Checkin | |
| 2016-12-28 09:59 | hgbot | Note Added: 0093036 | |
| 2016-12-28 09:59 | hgbot | Status | scheduled => resolved |
| 2016-12-28 09:59 | hgbot | Resolution | open => fixed |
| 2016-12-28 09:59 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/727ec6dd252256acce4935d1d69654e5339e100c [^] |
| 2016-12-29 13:22 | mtaal | Note Added: 0093052 | |
| 2016-12-29 13:22 | mtaal | Status | resolved => closed |
| 2016-12-29 13:22 | mtaal | Fixed in Version | => RR17Q1 |
| 2017-03-09 10:28 | mtaal | Relationship added | related to 0035292 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |